fix: use iifname for input interface name matches#134024
fix: use iifname for input interface name matches#134024k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
|
|
|
Welcome @jack4it! |
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @jack4it. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign @danwinship @aroradaman based on https://wiki.nftables.org/wiki-nftables/index.php/Matching_packet_metainformation it looks correct, /ok-to-test |
|
/retest-required |
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 84ba230a77262661c9c66504219dad03c576b6d2 |
|
@jack4it one final request sorry, do you mind to squash the commits? so we backport the fix and the unit test altogether in one commit |
add tests to cover nftables; also fix NewDetectLocalByBridgeInterface
1096f44 to
b81e87c
Compare
|
/lgtm Thanks, @jack4it since we do not seem to have CI on this mode and you find it, I assume you already validated this works fine, right? |
ok, then I put it on hold and you just do /hold the PR is already approved and it will marge if no changes are done |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, aroradaman, jack4it The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Once verified we should back port this to v1.33 as well. |
|
kindly ping @jack4it 😄 |
|
circling back. had a successful integration test /hold cancel |
…024-upstream-release-1.33 Automated cherry pick of #134024: fix: use iifname for input interface name matches
…024-upstream-release-1.34 Automated cherry pick of #134024: fix: use iifname for input interface name matches
…134024-upstream-release-1.33 Automated cherry pick of #134024: fix: use iifname for input interface name matches
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes a bug in the nftables support of kube-proxy. An example error without this fix. Notice that
iifwas mistakenly used instead ofiifnamein that.Which issue(s) this PR is related to:
KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/3866-nftables-proxy/README.md
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: