Skip to content

Re-enable SchedulerAsyncAPICalls feature in v1.35#135059

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
macsko:reenable_async_api_calls
Nov 5, 2025
Merged

Re-enable SchedulerAsyncAPICalls feature in v1.35#135059
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
macsko:reenable_async_api_calls

Conversation

@macsko
Copy link
Copy Markdown
Member

@macsko macsko commented Nov 3, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

SchedulerAsyncAPICalls feature gate was disabled because of a known regressions related to asynchronous preemption (#134400). Now, as these issues were resolved (#134157, #134927, #134730), we can re-enable the feature gate.

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The SchedulerAsyncAPICalls feature gate has been re-enabled by default after fixing regressions detected in v1.34.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 3, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 3, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 3, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 3, 2025
@macsko macsko marked this pull request as ready for review November 4, 2025 14:22
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2025
@macsko
Copy link
Copy Markdown
Member Author

macsko commented Nov 4, 2025

/cc @dom4ha @sanposhiho

@macsko
Copy link
Copy Markdown
Member Author

macsko commented Nov 4, 2025

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Nov 4, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 4, 2025
sanposhiho
sanposhiho approved these changes Nov 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for all the fixes on this issue!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 5, 2025

LGTM label has been added.

DetailsGit tree hash: bcf92da0f702470d2aff397f334384d35ec960c3

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: macsko, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 22d41b5 into kubernetes:master Nov 5, 2025
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@thockin thockin Awaiting requested review from thockin

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

@dom4ha dom4ha Awaiting requested review from dom4ha

1 more reviewer

@sanposhiho sanposhiho sanposhiho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sanposhiho sanposhiho

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

SIG Scheduling
Archived in project

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

3 participants

@macsko @k8s-ci-robot @sanposhiho