Skip to content

Drop support for networkingv1beta1.IngressClass in kubectl#135108

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
scaliby:remove-deprecated-ic-api
Nov 5, 2025
Merged

Drop support for networkingv1beta1.IngressClass in kubectl#135108
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
scaliby:remove-deprecated-ic-api

Conversation

@scaliby
Copy link
Copy Markdown
Member

@scaliby scaliby commented Nov 4, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

It cleans up deprecated networkingv1beta1.IngressClass so we will not have to modify ResourceDescriber logic for it when implementing kubernetes/kubectl#1769 and #133498.

Which issue(s) this PR is related to:

kubernetes/kubectl#1769

Does this PR introduce a user-facing change?

Dropped support for networking/v1beta1 IngressClass in kubectl

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Nov 4, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 4, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG CLI Nov 4, 2025
soltysh
soltysh approved these changes Nov 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 5, 2025

LGTM label has been added.

DetailsGit tree hash: 59b202f610054629b3f27a40fa7c5abd9316c6f7

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Nov 5, 2025

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 5, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: scaliby, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit 07faa17 into kubernetes:master Nov 5, 2025
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Nov 5, 2025
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in SIG CLI Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh soltysh approved these changes

@mpuckett159 mpuckett159 Awaiting requested review from mpuckett159

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG CLI
Archived in project

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

3 participants

@scaliby @k8s-ci-robot @soltysh