Skip to content

Remove flakiness in tests #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kudima03 merged 1 commit into from
May 15, 2026
Merged

Remove flakiness in tests #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Tests/Pure.Primitives.Random.Tests/Bool/RandomBoolCollectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public void ProduceNormalDistributionWithSharedProvider()
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 0.48, 0.5);
Assert.InRange(stdDev, 0.45, 0.53);
}

[Fact]
Expand All @@ -63,7 +63,7 @@ public void ProduceNormalDistribution()
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 0.48, 0.5);
Assert.InRange(stdDev, 0.45, 0.53);
}

[Fact]
Expand Down
4 changes: 2 additions & 2 deletions src/Tests/Pure.Primitives.Random.Tests/Bool/RandomBoolTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ .. Enumerable
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 0.48, 0.5);
Assert.InRange(stdDev, 0.45, 0.53);
}

[Fact]
Expand All @@ -44,7 +44,7 @@ .. Enumerable
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 0.48, 0.5);
Assert.InRange(stdDev, 0.45, 0.53);
}

[Fact]
Expand Down
6 changes: 3 additions & 3 deletions src/Tests/Pure.Primitives.Random.Tests/Date/RandomDateCollectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public void ProduceNormalStandardDeviationOnDay()
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 8.7, 9);
Assert.InRange(stdDev, 7.0, 10.5);
}

[Fact]
Expand All @@ -79,7 +79,7 @@ public void ProduceNormalStandardDeviationOnMonth()
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 3.4, 3.6);
Assert.InRange(stdDev, 2.8, 3.9);
}

[Fact]
Expand All @@ -98,7 +98,7 @@ public void ProduceNormalStandardDeviationOnYear()
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 2750, 2950);
Assert.InRange(stdDev, 2500, 3300);
}

[Fact]
Expand Down
6 changes: 3 additions & 3 deletions src/Tests/Pure.Primitives.Random.Tests/Date/RandomDateTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ .. Enumerable
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 8.7, 9);
Assert.InRange(stdDev, 7.0, 10.5);
}

[Fact]
Expand All @@ -61,7 +61,7 @@ .. Enumerable
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 3.4, 3.6);
Assert.InRange(stdDev, 2.8, 3.9);
}

[Fact]
Expand All @@ -82,7 +82,7 @@ .. Enumerable
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 2750, 2950);
Assert.InRange(stdDev, 2500, 3300);
}

[Fact]
Expand Down
18 changes: 9 additions & 9 deletions src/Tests/Pure.Primitives.Random.Tests/DateTime/RandomDateTimeCollectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public void ProduceNormalStandardDeviationOnDay()
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 8.6, 9);
Assert.InRange(stdDev, 7.0, 10.5);
}

[Fact]
Expand All @@ -99,7 +99,7 @@ public void ProduceNormalStandardDeviationOnMonth()
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 3.3, 3.6);
Assert.InRange(stdDev, 2.8, 3.9);
}

[Fact]
Expand All @@ -118,7 +118,7 @@ public void ProduceNormalStandardDeviationOnYear()
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 2750, 3000);
Assert.InRange(stdDev, 2500, 3300);
}

[Fact]
Expand All @@ -137,7 +137,7 @@ public void ProduceNormalStandardDeviationOnHour()
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 6.8, 7.2);
Assert.InRange(stdDev, 6.0, 8.0);
}

[Fact]
Expand All @@ -156,7 +156,7 @@ public void ProduceNormalStandardDeviationOnMinute()
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 16, 18);
Assert.InRange(stdDev, 15.0, 19.5);
}

[Fact]
Expand All @@ -175,7 +175,7 @@ public void ProduceNormalStandardDeviationOnSecond()
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 17, 17.6);
Assert.InRange(stdDev, 15.0, 19.5);
}

[Fact]
Expand All @@ -194,7 +194,7 @@ public void ProduceNormalStandardDeviationOnMillisecond()
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 280, 300);
Assert.InRange(stdDev, 255, 325);
}

[Fact]
Expand All @@ -213,7 +213,7 @@ public void ProduceNormalStandardDeviationOnMicrosecond()
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 280, 300);
Assert.InRange(stdDev, 255, 325);
}

[Fact]
Expand All @@ -232,7 +232,7 @@ public void ProduceNormalStandardDeviationOnNanosecond()
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 280, 300);
Assert.InRange(stdDev, 255, 325);
}

[Fact]
Expand Down
18 changes: 9 additions & 9 deletions src/Tests/Pure.Primitives.Random.Tests/DateTime/RandomDateTimeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ .. Enumerable
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 8.7, 9);
Assert.InRange(stdDev, 7.0, 10.5);
}

[Fact]
Expand All @@ -78,7 +78,7 @@ .. Enumerable
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 3.4, 3.6);
Assert.InRange(stdDev, 2.8, 3.9);
}

[Fact]
Expand All @@ -99,7 +99,7 @@ .. Enumerable
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 2750, 2950);
Assert.InRange(stdDev, 2500, 3300);
}

[Fact]
Expand All @@ -120,7 +120,7 @@ .. Enumerable
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 6.8, 7);
Assert.InRange(stdDev, 6.0, 8.0);
}

[Fact]
Expand All @@ -141,7 +141,7 @@ .. Enumerable
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 17, 17.5);
Assert.InRange(stdDev, 15.0, 19.5);
}

[Fact]
Expand All @@ -162,7 +162,7 @@ .. Enumerable
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 17, 17.5);
Assert.InRange(stdDev, 15.0, 19.5);
}

[Fact]
Expand All @@ -183,7 +183,7 @@ .. Enumerable
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 280, 300);
Assert.InRange(stdDev, 255, 325);
}

[Fact]
Expand All @@ -204,7 +204,7 @@ .. Enumerable
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 280, 300);
Assert.InRange(stdDev, 255, 325);
}

[Fact]
Expand All @@ -225,7 +225,7 @@ .. Enumerable
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 280, 300);
Assert.InRange(stdDev, 255, 325);
}

[Fact]
Expand Down
4 changes: 2 additions & 2 deletions src/Tests/Pure.Primitives.Random.Tests/DayOfWeek/RandomDayOfWeekCollectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public void ProduceNormalStandardDeviationWithSharedProvider()
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 2.1, 2.4);
Assert.InRange(stdDev, 1.7, 2.4);
}

[Fact]
Expand All @@ -63,7 +63,7 @@ public void ProduceNormalStandardDeviation()
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 2.1, 2.4);
Assert.InRange(stdDev, 1.7, 2.4);
}

[Fact]
Expand Down
4 changes: 2 additions & 2 deletions src/Tests/Pure.Primitives.Random.Tests/DayOfWeek/RandomDayOfWeekTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ .. Enumerable
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 2.1, 2.4);
Assert.InRange(stdDev, 1.7, 2.4);
}

[Fact]
Expand All @@ -44,7 +44,7 @@ .. Enumerable
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 2.1, 2.4);
Assert.InRange(stdDev, 1.7, 2.4);
}

[Fact]
Expand Down
4 changes: 2 additions & 2 deletions src/Tests/Pure.Primitives.Random.Tests/Number/RandomIntCollectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public void ProduceNormalStandardDeviationWithSharedProvider()
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 1225000000, 1255000000);
Assert.InRange(stdDev, 1190000000, 1290000000);
}

[Fact]
Expand All @@ -77,7 +77,7 @@ public void ProduceNormalStandardDeviation()
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 1225000000, 1255000000);
Assert.InRange(stdDev, 1190000000, 1290000000);
}

[Fact]
Expand Down
4 changes: 2 additions & 2 deletions src/Tests/Pure.Primitives.Random.Tests/Number/RandomIntTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ .. Enumerable
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 1225000000, 1255000000);
Assert.InRange(stdDev, 1190000000, 1290000000);
}

[Fact]
Expand All @@ -71,7 +71,7 @@ .. Enumerable
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 1225000000, 1255000000);
Assert.InRange(stdDev, 1190000000, 1290000000);
}

[Fact]
Expand Down
4 changes: 2 additions & 2 deletions src/Tests/Pure.Primitives.Random.Tests/Number/RandomUIntCollectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public void ProduceNormalStandardDeviationWithSharedProvider()
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 1225000000, 1255000000);
Assert.InRange(stdDev, 1190000000, 1290000000);
}

[Fact]
Expand All @@ -79,7 +79,7 @@ public void ProduceNormalStandardDeviation()
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 1225000000, 1255000000);
Assert.InRange(stdDev, 1190000000, 1290000000);
}

[Fact]
Expand Down
4 changes: 2 additions & 2 deletions src/Tests/Pure.Primitives.Random.Tests/Number/RandomUIntTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ .. Enumerable
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 1225000000, 1255000000);
Assert.InRange(stdDev, 1190000000, 1290000000);
}

[Fact]
Expand All @@ -71,7 +71,7 @@ .. Enumerable
double variance = values.Average(v => Math.Pow(v - mean, 2));
double stdDev = Math.Sqrt(variance);

Assert.InRange(stdDev, 1225000000, 1255000000);
Assert.InRange(stdDev, 1190000000, 1290000000);
}

[Fact]
Expand Down
Loading
Loading