Fix flaky ProduceDifferentLengths test#162
Merged
kudima03 merged 2 commits intoMay 25, 2026
Merged
Conversation
kudima03
requested changes
May 25, 2026
| ]; | ||
|
|
||
| Assert.Equal(lengths.Count, lengths.Distinct().Count()); | ||
| Assert.True(lengths.Distinct().Count() > 1); |
Owner
There was a problem hiding this comment.
Previous test ensures: All element lengths are different
Assert.Equal(lengths.Count, lengths.Distinct().Count());
Current test ensures: At least 1 element length is different from the others
Assert.True(lengths.Distinct().Count() > 1);
It means test case degradation
Probably you should use such way (pseudocode):
Suggested change
| Assert.True(lengths.Distinct().Count() > 1); | |
| Assert.InRange(lengths.Distinct().Count(), 49, 50); |
StanislavKozachenko
force-pushed
the
fix/flaky-string-collection-test
branch
from
cb7f4cd to
df6e180
Compare
kudima03
approved these changes
May 25, 2026
Owner
|
@StanislavKozachenko Thanks for contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #161