feat: enable type check when isolatedModules and diagnostics === true#4866
Closed
toomuchdesign wants to merge 1 commit intokulshekhar:mainfrom
Closed
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Author
|
Closed if favour of #4868 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TS config
isolatedModulesdisables type check. #4859Solution (just a RFC)
This solution is a basic RFC to temporarily enable provide the ability to execute type check when
isolatedModulesanddiagnosticsare true.Currently
isolatedModules=== true disable type check no matter any other configurationIn the next major I believe
ts-jestshould handleisolatedModulesso that it never disables type check.Demo
I've temporarily tested the change in this repro and it seems to work.
Does this PR introduce a breaking change?
Technically yes (in case of
isolatedModulesanddiagnostics=== true). But it could be interpreted as a fix.Other information
Opening this PR as a draft just for sharing purposes.
I haven't found a way to test it, yet. My code addition didn't influence tests.