Skip to content

feat(kuma-cp) localhost is not an admin on kubernetes#3003

Merged
jakubdyszkiewicz merged 4 commits intomasterfrom
chore/local-admin-false-kubernetes
Oct 26, 2021
Merged

feat(kuma-cp) localhost is not an admin on kubernetes#3003
jakubdyszkiewicz merged 4 commits intomasterfrom
chore/local-admin-false-kubernetes

Conversation

@jakubdyszkiewicz
Copy link
Contributor

Summary

Follow up to bootstrap admin token. On Kubernetes, we create token and mesh operator can access it by executing kubectl get secrets -n kuma-system. There is no need to enable localhost is admin functionality.

Issues resolved

No issue

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • No backporting

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner October 25, 2021 13:28
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2021

Codecov Report

Merging #3003 (d0ff354) into master (6f9137a) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3003      +/-   ##
==========================================
- Coverage   52.26%   52.25%   -0.01%     
==========================================
  Files         913      913              
  Lines       52805    52840      +35     
==========================================
+ Hits        27596    27611      +15     
- Misses      23011    23029      +18     
- Partials     2198     2200       +2     
Impacted Files Coverage Δ
...atibility/cp_compatibility_kubernetes_multizone.go 0.00% <0.00%> (ø)
test/e2e/helm/kuma_helm_upgrade.go 0.00% <0.00%> (ø)
test/framework/k8s_cluster.go 0.00% <0.00%> (ø)
test/framework/k8s_controlplane.go 0.00% <0.00%> (ø)
pkg/kds/client/sink.go 59.45% <0.00%> (-2.71%) ⬇️
pkg/core/resources/model/rest/resource.go 69.23% <0.00%> (+1.28%) ⬆️
pkg/dns/vips_allocator.go 74.00% <0.00%> (+1.33%) ⬆️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (+2.59%) ⬆️
pkg/plugins/runtime/gateway/route/sorter.go 66.66% <0.00%> (+5.12%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f9137a...d0ff354. Read the comment docs.

Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jakubdyszkiewicz jakubdyszkiewicz merged commit 9aeea34 into master Oct 26, 2021
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/local-admin-false-kubernetes branch October 26, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants