Skip to content

feat(kuma-cp) Add kuma.io/ignore annotation#3142

Merged
lahabana merged 1 commit intokumahq:masterfrom
lahabana:feat/ignoreAnnotation
Nov 12, 2021
Merged

feat(kuma-cp) Add kuma.io/ignore annotation#3142
lahabana merged 1 commit intokumahq:masterfrom
lahabana:feat/ignoreAnnotation

Conversation

@lahabana
Copy link
Contributor

Summary

This annotation ignores a kubernetes resource when generating kuma configuration
It currently only works for service and it's meant to be used when migrating to kuma
where you might have services that are used outside of kuma and that will be removed
once migration is complete

Full changelog

  • Add annotation
  • Add support in serviceController
  • Add support in podController

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

This annotation ignores a kubernetes resource when generating kuma configuration
It currently only works for service and it's meant to be used when migrating to kuma
where you might have services that are used outside of kuma and that will be removed
once migration is complete

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana requested a review from a team as a code owner November 12, 2021 09:22
@codecov-commenter
Copy link

Codecov Report

Merging #3142 (ea0032b) into master (95d176b) will increase coverage by 0.05%.
The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3142      +/-   ##
==========================================
+ Coverage   52.32%   52.38%   +0.05%     
==========================================
  Files         923      923              
  Lines       53578    53596      +18     
==========================================
+ Hits        28035    28076      +41     
+ Misses      23306    23289      -17     
+ Partials     2237     2231       -6     
Impacted Files Coverage Δ
pkg/plugins/runtime/k8s/metadata/annotations.go 90.90% <ø> (+4.54%) ⬆️
...gins/runtime/k8s/controllers/service_controller.go 37.50% <80.00%> (+5.79%) ⬆️
.../plugins/runtime/k8s/controllers/pod_controller.go 42.21% <100.00%> (ø)
pkg/plugins/runtime/k8s/util/util.go 100.00% <100.00%> (ø)
pkg/plugins/resources/postgres/store.go 75.52% <0.00%> (+0.84%) ⬆️
pkg/core/managers/apis/mesh/mesh_manager.go 49.38% <0.00%> (+2.46%) ⬆️
pkg/defaults/mesh/mesh.go 77.77% <0.00%> (+3.70%) ⬆️
pkg/defaults/components.go 92.15% <0.00%> (+3.92%) ⬆️
pkg/plugins/runtime/gateway/route/sorter.go 66.66% <0.00%> (+5.12%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95d176b...ea0032b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants