feat(kuma-cp): support Retry policy for Gateways#3402
Merged
jpeach merged 1 commit intokumahq:masterfrom Dec 2, 2021
jpeach:feat/gateway-retry-support
Merged
feat(kuma-cp): support Retry policy for Gateways#3402jpeach merged 1 commit intokumahq:masterfrom jpeach:feat/gateway-retry-support
jpeach merged 1 commit intokumahq:masterfrom
jpeach:feat/gateway-retry-support
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3402 +/- ##
==========================================
+ Coverage 52.18% 52.26% +0.08%
==========================================
Files 940 941 +1
Lines 54677 54837 +160
==========================================
+ Hits 28532 28663 +131
- Misses 23927 23946 +19
- Partials 2218 2228 +10
Continue to review full report at Codecov.
|
michaelbeaumont
approved these changes
Dec 1, 2021
jakubdyszkiewicz
approved these changes
Dec 2, 2021
Add Retry support to Gateway routes. This takes a different approach from mesh, but populating the retry policy on the routing route action. Since Retry is a connection policy that matches a sources and destination, the routing step is the best place to attach the policy since at that point we know both the source and the destination services. The only complication is when we are forwarding to a weighted cluster composed of multiple services, where the selected policy may not be especially obvious. This fixes #3319. Signed-off-by: James Peach <james.peach@konghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Retry support to Gateway routes. This takes a different approach
from mesh, but populating the retry policy on the routing route action.
Since Retry is a connection policy that matches a sources and destination,
the routing step is the best place to attach the policy since at that
point we know both the source and the destination services. The only
complication is when we are forwarding to a weighted cluster composed
of multiple services, where the selected policy may not be especially
obvious.
Full changelog
N/A
Issues resolved
Fix #3319.
Documentation
N/A
Testing
Backwards compatibility
UPGRADE.mdwith any steps users will need to takewhen upgrading.
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.