Skip to content

chore(kuma-cp): minor CRD type cleanups#3452

Merged
jpeach merged 1 commit intokumahq:masterfrom
jpeach:chore/crd-type-cleanup
Dec 9, 2021
Merged

chore(kuma-cp): minor CRD type cleanups#3452
jpeach merged 1 commit intokumahq:masterfrom
jpeach:chore/crd-type-cleanup

Conversation

@jpeach
Copy link
Contributor

@jpeach jpeach commented Dec 9, 2021

Summary

Minor formatting update to the CRD types.

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach requested a review from a team as a code owner December 9, 2021 01:26
@codecov-commenter
Copy link

Codecov Report

Merging #3452 (52750b9) into master (1d984c8) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3452      +/-   ##
==========================================
- Coverage   52.30%   52.28%   -0.02%     
==========================================
  Files         939      939              
  Lines       54441    54441              
==========================================
- Hits        28474    28465       -9     
- Misses      23744    23752       +8     
- Partials     2223     2224       +1     
Impacted Files Coverage Δ
...k8s/native/api/v1alpha1/dataplane_insight_types.go 100.00% <ø> (ø)
...sources/k8s/native/api/v1alpha1/dataplane_types.go 100.00% <ø> (ø)
...s/k8s/native/api/v1alpha1/externalservice_types.go 100.00% <ø> (ø)
.../k8s/native/api/v1alpha1/virtual_outbound_types.go 100.00% <ø> (ø)
.../native/api/v1alpha1/zone_ingress_insight_types.go 100.00% <ø> (ø)
pkg/core/runtime/component/component.go 81.13% <0.00%> (-7.55%) ⬇️
pkg/core/resources/manager/cache.go 83.11% <0.00%> (-2.60%) ⬇️
pkg/dns/vips_allocator.go 72.34% <0.00%> (-1.42%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 84.70% <0.00%> (-1.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d984c8...52750b9. Read the comment docs.

@jpeach jpeach merged commit 11c77ee into kumahq:master Dec 9, 2021
@jpeach jpeach deleted the chore/crd-type-cleanup branch December 9, 2021 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants