Calculate disk stats on linux for correct mount point instead of /#4683
Merged
timothycoleman merged 3 commits intomasterfrom Jan 22, 2025
Merged
Calculate disk stats on linux for correct mount point instead of /#4683timothycoleman merged 3 commits intomasterfrom
/#4683timothycoleman merged 3 commits intomasterfrom
Conversation
Fix for bug introduced after 23.10.x series
Contributor
…'t mapped, which is unlikely irl but happening in some of the memdb? tests)
timothycoleman
force-pushed
the
timothycoleman/fix-disk-stats
branch
from
ec735e6 to
da9c611
Compare
Contributor
|
tested on MacOS Sequoia 15.2 M2 MAX and the values seem ok. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🚨 @timothycoleman Failed to create cherry Pick PR due to error:
ReferenceError: oktokit is not defined
at createPullRequest (/home/runner/work/_actions/EventStore/Automations/master/lib/index.js:177:5)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async createPullRequestWithCherryPick (/home/runner/work/_actions/EventStore/Automations/master/cherry-pick-pr-for-label/index.js:66:40)
at async run (/home/runner/work/_actions/EventStore/Automations/master/cherry-pick-pr-for-label/index.js:143:25)
🚨👉 Check https://github.com/EventStore/EventStore/actions/runs/12908449728
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: Disk stats bug introduced in 24.6.0. On Linux the disk usage/capacity were showing the values for the disk mounted at
/even if the database was on a different diskFixes #4680