-
Notifications
You must be signed in to change notification settings - Fork 672
Add some missing formatting in the rabbitmq docs sink #4993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying eventstore with
|
| Latest commit: |
792c550
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://82e06275.eventstore.pages.dev |
| Branch Preview URL: | https://rabbitmq-docs-formatting.eventstore.pages.dev |
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 @Deflaimun Failed to create cherry Pick PR due to error:
RequestError [HttpError]: Merge conflict
at /home/runner/work/_actions/EventStore/Automations/master/cherry-pick-pr-for-label/node_modules/@octokit/request/dist-node/index.js:66:23
at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
status: '409',
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
'content-length': '127',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Wed, 09 Apr 2025 13:45:22 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'github.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-github-permissions': 'contents=write',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-api-version-selected': '2022-11-28',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': 'F401:1A0416:B3353A:16597DA:67F679F1',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4990',
'x-ratelimit-reset': '1744209918',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '10',
'x-xss-protection': '0'
},
request: {
method: 'POST',
url: 'https://api.github.com/repos/kurrent-io/EventStore/merges',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'octokit-core.js/3.3.2 Node.js/20.19.0 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"base":"cherry-pick-cherry-pick/4993/rabbitmq-docs-formatting-release/v24.10-72c9faf5-54bf-42aa-ace7-57de194bbcf6","commit_message":"Merge 2784a0f335e5e491dc8043e27d431beecc736284 into cherry-pick-cherry-pick/4993/rabbitmq-docs-formatting-release/v24.10-72c9faf5-54bf-42aa-ace7-57de194bbcf6 [skip ci]\\n\\n\\nskip-checks: true\\n","head":"2784a0f335e5e491dc8043e27d431beecc736284"}',
request: { agent: [Agent], hook: [Function: bound bound register] }
},
documentation_url: 'https://docs.github.com/rest/branches/branches#merge-a-branch'
}
🚨👉 Check https://github.com/kurrent-io/EventStore/actions/runs/14358778026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Deflaimun 👉 Created pull request targeting release/v25.0: #4994
* Add some missing formatting in the rabbitmq docs sink * Update rabbitmq.md # Conflicts: # docs/server/features/connectors/sinks/rabbitmq.md
|
Cherry-pick for 24.10 |
Noticed some missing formatting while reading the docs