Fix argument types and improve message retrieval method#754
Merged
Conversation
TitleFix argument types and improve message retrieval method Description
Changes walkthrough 📝
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
|
||
| """ | ||
| messages = cast(list[InternationalizationMessageItem], internationalization_message["messages"]) | ||
| messages = internationalization_message["messages"] |
There was a problem hiding this comment.
Suggestion: InternationalizationMessageが辞書型ではなく属性アクセスを想定する場合、["messages"]ではなく属性のmessagesを使うことで実行時エラーを回避できます。 [possible issue, importance: 8]
Suggested change
| messages = internationalization_message["messages"] | |
| messages = internationalization_message.messages |
|
|
||
| """ | ||
| messages = cast(list[InternationalizationMessageItem], internationalization_message["messages"]) | ||
| messages = internationalization_message["messages"] |
There was a problem hiding this comment.
Suggestion: 取得したmessagesがリストであることを確認し、想定外の型だった場合にNoneを返すことで安全性を高めます。 [possible issue, importance: 4]
Suggested change
| messages = internationalization_message["messages"] | |
| messages = internationalization_message["messages"] | |
| if not isinstance(messages, list): | |
| return None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.