This repository was archived by the owner on Sep 28, 2022. It is now read-only.
SDK new architecture w/ WebSocket#40
Merged
Merged
Conversation
added 8 commits
August 21, 2019 14:24
added 2 commits
August 30, 2019 16:49
added 2 commits
September 11, 2019 10:14
Aschen
suggested changes
Nov 27, 2019
| } | ||
|
|
||
| Task<Response> task = requests.get( | ||
| notNull(response.requestId, "")); |
Contributor
There was a problem hiding this comment.
Kuzzle always set the requestId, I think that a payload that does not contain this property should be rejected in some way by the Response object.
(So you won't need the notNull method)
This PR adds the unit tests for Kuzzle and WebSocket. Run cd kuzzle-sdk-java && ./gradlew test
This reverts commit 9b383ba.
…ket-unit-tests Revert "SDK V3 WebSocket Unit Tests"
…-v3-websocket-unit-tests Revert "Revert "SDK V3 WebSocket Unit Tests""
xbill82
reviewed
Dec 11, 2019
| * @param <T> Object class. | ||
| * @return The object or the specified default value in case the object is null. | ||
| */ | ||
| public static <T> T notNull(T obj, T defaultValue) { |
Contributor
There was a problem hiding this comment.
Nitpicking: I don't agree with this naming.
To me, notNull sounds more like an assertion that throws if the argument is null. I'd prefer something like default, which mimics the _.default() from lodash. This is surely because I come from the web/JS domain...
| @@ -0,0 +1,8 @@ | |||
| package io.kuzzle.sdk.CoreClasses.Maps; | |||
|
|
|||
| public class Null { | |||
Contributor
Author
There was a problem hiding this comment.
Nothing except the fact that we need an object that represent a null value without being null, because ConcurrentHashMap can't have null value associated to a key
added 5 commits
December 11, 2019 13:03
Aschen
approved these changes
Jan 6, 2020
scottinet
approved these changes
Jan 7, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR adds the Kuzzle and WebSocket class plus :
How should this be manually tested?
Run
cd kuzzle-sdk-java && ./gradlew test