Skip to content
This repository was archived by the owner on Sep 28, 2022. It is now read-only.

Kzl 1347/Auth controller#43

Closed
Shiranuit wants to merge 15 commits into
KZL-1346/sdk-v3-websocket-unit-testsfrom
KZL-1347/AuthController
Closed

Kzl 1347/Auth controller#43
Shiranuit wants to merge 15 commits into
KZL-1346/sdk-v3-websocket-unit-testsfrom
KZL-1347/AuthController

Conversation

@Shiranuit
Copy link
Copy Markdown
Contributor

@Shiranuit Shiranuit commented Sep 11, 2019

⚠️ Depends on [#41]

What does this PR do ?

This PR adds the AuthController

How should this be manually tested?

Run cd kuzzle-sdk-java && ./gradlew test

@Shiranuit Shiranuit changed the base branch from KZL-1346/sdk-v3-websocket to KZL-1346/sdk-v3-websocket-unit-tests September 11, 2019 08:43
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (KZL-1346/sdk-v3-websocket-unit-tests@1f2f9dc). Click here to learn what that means.
The diff coverage is 13.63%.

Impacted file tree graph

@@                           Coverage Diff                           @@
##             KZL-1346/sdk-v3-websocket-unit-tests      #43   +/-   ##
=======================================================================
  Coverage                                        ?   64.26%           
  Complexity                                      ?       77           
=======================================================================
  Files                                           ?       20           
  Lines                                           ?      375           
  Branches                                        ?       29           
=======================================================================
  Hits                                            ?      241           
  Misses                                          ?      114           
  Partials                                        ?       20
Impacted Files Coverage Δ Complexity Δ
.../io/kuzzle/sdk/API/Controllers/BaseController.java 100% <100%> (ø) 1 <1> (?)
...se/src/main/java/io/kuzzle/sdk/AbstractKuzzle.java 60% <100%> (ø) 13 <0> (?)
.../io/kuzzle/sdk/API/Controllers/AuthController.java 5% <5%> (ø) 1 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f2f9dc...1aee236. Read the comment docs.

@Shiranuit Shiranuit added the wip label Sep 11, 2019
@Shiranuit Shiranuit self-assigned this Sep 11, 2019
@Shiranuit Shiranuit closed this Oct 10, 2019
@Shiranuit Shiranuit reopened this Oct 10, 2019
@Shiranuit Shiranuit added wip and removed wip labels Nov 25, 2019
@jenow
Copy link
Copy Markdown
Contributor

jenow commented Jan 20, 2020

Continue this work on #52

@jenow jenow closed this Jan 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants