This repository was archived by the owner on Sep 28, 2022. It is now read-only.
Add Index controller#57
Merged
Merged
Conversation
Aschen
suggested changes
Feb 20, 2020
Contributor
Aschen
left a comment
Aschen
left a comment
There was a problem hiding this comment.
Some nitpicking on the documentation, apart from that 👍
Co-Authored-By: Adrien Maret <amaret93@gmail.com>
Aschen
approved these changes
Feb 24, 2020
Aschen
suggested changes
Feb 24, 2020
Contributor
Aschen
left a comment
Aschen
left a comment
There was a problem hiding this comment.
Can you at least instantiate an object to get the response from the API and when it's possible print something with it on STDOUT to have more robust snippet tests?
Aschen
approved these changes
Feb 24, 2020
Contributor
Aschen
left a comment
Aschen
left a comment
There was a problem hiding this comment.
Didn't see your clever system to print the result 👍
https://github.com/kuzzleio/sdk-java/blob/3-dev/.ci/doc/templates/print-result.tpl.java
scottinet
approved these changes
Feb 25, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add Index Controller.
How should this be manually tested?
./gradlew testOther changes
KuzzleExceptionCode.MISSING_QUERY