This repository was archived by the owner on Sep 28, 2022. It is now read-only.
Add document:search#77
Merged
Merged
Conversation
Aschen
suggested changes
Apr 10, 2020
|
|
||
| Searches document. | ||
|
|
||
| There is a limit to how many documents can be returned by a single search query. |
Contributor
There was a problem hiding this comment.
IMHO this should be a warning
| | `documents` | ArrayList<ConcurrentHashMap<String, Object>> | An array of instantiated Document objects | get | | ||
| | `fetched` | Integer | The number of fetched documents so far | get/set | | ||
| | `options` | SearchOptions | The arguments of the search/scroll request | get | | ||
| | `filters` | object | The filters of the search request | get | |
Contributor
There was a problem hiding this comment.
isn't this a ConcurrentHashMap?
| ## Arguments | ||
|
|
||
| ```java | ||
| next(); |
| return nextRequest; | ||
| } | ||
|
|
||
| public SearchResult next() throws NotConnectedException, InternalException, ExecutionException, InterruptedException { |
Contributor
There was a problem hiding this comment.
Calls to next() are not async?
Contributor
Author
There was a problem hiding this comment.
I've changed it, its now async
Co-Authored-By: Adrien Maret <amaret93@gmail.com>
Co-Authored-By: Adrien Maret <amaret93@gmail.com>
Co-Authored-By: Adrien Maret <amaret93@gmail.com>
Co-Authored-By: Adrien Maret <amaret93@gmail.com>
Co-Authored-By: Adrien Maret <amaret93@gmail.com>
Aschen
approved these changes
Apr 17, 2020
| } | ||
|
|
||
| public CompletableFuture<SearchResult> next() throws NotConnectedException, InternalException, ExecutionException, InterruptedException { | ||
| System.out.println("fetched: " + this.fetched + " total: " + this.total); |
jenow
approved these changes
Apr 22, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR adds
document:searchwith its units tests and theSearchResultclass.Sample code :
How should this be manually tested?
...
Other changes
Correct how
refreshoption is passed and adapt testsBoyscout