This repository was archived by the owner on Sep 28, 2022. It is now read-only.
Add collection:list#82
Merged
Merged
Conversation
Aschen
reviewed
Apr 1, 2020
| } | ||
|
|
||
| public Integer getFrom() { | ||
| return from; |
Contributor
There was a problem hiding this comment.
What is returned when the uninitialized value is returned? The request contain a number or null?
Contributor
Author
There was a problem hiding this comment.
If its uninitialized it returns null
Aschen
approved these changes
Apr 2, 2020
scottinet
suggested changes
Apr 15, 2020
| | Arguments | Type | Description | | ||
| | --------- | ---------------------- | ------------- | | ||
| | `index` | <pre>String</pre> | Index name | | ||
| | `options` | <pre>ListOptions</pre> | List options | |
Contributor
There was a problem hiding this comment.
I think we should get rid of these optional parameters: kuzzleio/kuzzle#1592
I'd prefer if you remove them, but if you don't, then the default values for the from and size parameters should be null from this SDK's point of view.
Contributor
Author
There was a problem hiding this comment.
I've didnt see that, thanks
scottinet
approved these changes
Apr 20, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR implements the
collection:listmethod with its unit tests.How should this be manually tested?
Clone this branch and run unit tests
./gradlew testWhen it succeed, compile it
./gradlew jarInitiate another java project by adding the compiled SDK as a dependency.
Then, run Kuzzle, create an index
nyc-open-data, ayellow-taxicollection.Finally, run this code