This repository was archived by the owner on Sep 28, 2022. It is now read-only.
Add collection:updateSpecifications#85
Merged
Merged
Conversation
scottinet
suggested changes
Apr 7, 2020
|
|
||
| It must follow the [Specification Structure](/core/2/guides/essentials/data-validation): | ||
|
|
||
| ```java |
Contributor
There was a problem hiding this comment.
The content of this example doesn't appear to be written in java.
Given that there is already a code snippet in java, and JSON examples in the link you put a few lines back, then I think that this example should be removed.
Contributor
There was a problem hiding this comment.
I think it's the output of a println on the HashMap but still I agree with @scottinet, you should keep the JSON
Aschen
approved these changes
Apr 8, 2020
Contributor
Aschen
left a comment
There was a problem hiding this comment.
After @scottinet comment and this nitpicking, 👍
…date-specifications.java Co-Authored-By: Adrien Maret <amaret93@gmail.com>
…date-specifications.java Co-Authored-By: Adrien Maret <amaret93@gmail.com>
…:kuzzleio/sdk-java into KZL-1462-collection-updateSpecifications
scottinet
approved these changes
Apr 9, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR implements the
collection:updateSpecificationsmethod with its unit tests.How should this be manually tested?
Clone this branch and run unit tests
./gradlew testWhen it succeed, compile it
./gradlew jarInitiate another java project by adding the compiled SDK as a dependency.
Then, run Kuzzle, create an index
nyc-open-data, ayellow-taxicollectionFinally, run this code