Working implementation of DRY with one key issue I could use help with#30
Merged
l3utterfly merged 2 commits intol3utterfly:dry-samplerfrom Aug 8, 2024
wwoodsTM:test-dry-sampler
Merged
Working implementation of DRY with one key issue I could use help with#30l3utterfly merged 2 commits intol3utterfly:dry-samplerfrom wwoodsTM:test-dry-sampler
l3utterfly merged 2 commits intol3utterfly:dry-samplerfrom
wwoodsTM:test-dry-sampler
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to work from my initial testing, which I will continue with, but one important issue is that I had to move the "LLAMA_API void llama_sample_dry" function signature in llama.h to the C++ "LLAMA_API_INTERNAL" section at the bottom which I am guessing is not optimal and I assume may break certain kinds of compiles that need C compatibility? I had to do this due to my use of a vector in the function signature.