chore(slim): remove the bundled wgpu backend — extracted out-of-tree (#386 Phase 6c) - #429
Conversation
…hase 6c) wgpu is resolved out-of-tree now (`.backend = .wgpu` → the labelle-wgpu provider, flipped in #428), so the in-tree backends/wgpu/ slot is dead weight. Delete it + the assembler example + the coverage that built them in-tree: - Remove backends/wgpu/ (src/templates/build_fragments/manifest/build + example). - Remove examples/wgpu (the assembler-generated wgpu project) — its assembler-builds-a-wgpu-project coverage (incl. the Foundation/QuartzCore/Metal link-fragment regression guard) moved to labelle-wgpu's CI (PR #1). - CI: drop the `wgpu backend WAV parser tests` + `wgpu backend demo build (macOS)` steps and the `Generate + build the wgpu example` examples-integration step. - Tests: drop the desktop wgpu-artifacts unit test (no in-tree package to resolve) and the wgpu case from the in-tree-template preview regression list. Two backends now fully out of the assembler bundle (bgfx + wgpu). The agnostic external-fetch path stays covered by the `external-null` (nullfixture) step.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (31)
💤 Files with no reviewable changes (28)
📝 WalkthroughWalkthroughThe entire Changeswgpu Backend Removal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the in-tree WebGPU (wgpu) backend, including its source code, build files, templates, and example project, following its extraction into the external labelle-wgpu repository. Additionally, the associated unit tests in test/build_zig_tests.zig and test/preview_mode_tests.zig have been cleaned up to reflect this extraction. There are no review comments to evaluate, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
Second backend fully out of the bundle (after bgfx #420). wgpu resolves out-of-tree now (
.backend = .wgpu→ labelle-wgpu, flipped in #428).Changes
backends/wgpu/(src/templates/build_fragments/manifest/build + example).examples/wgpu— its assembler builds a wgpu project coverage (incl. the Foundation/QuartzCore/Metal link-fragment regression guard) moved to labelle-wgpu's CI (labelle-wgpu#1, an assembler-integration job on Metal).wgpu backend WAV parser tests+wgpu backend demo build (macOS)steps and theGenerate + build the wgpu exampleexamples-integration step.The agnostic external-fetch path stays covered by the
external-null(nullfixture) step.backend_registry'slookup("wgpu")derivation test stays (pure name→layout).Gated on labelle-wgpu#1 landing first (so the assembler-integration coverage is live before it's removed here).
zig build+zig build testgreen.Summary by CodeRabbit