feat(config): flip .backend = .sdl to the extracted package by default (#386) - #447
Conversation
#386) builtinProvider(.sdl) → labelle-sdl 0.1.0 — sdl is the 4th default-external backend (after bgfx/wgpu/null). Desktop-only, loop-style; inherits the cache fetch-path + manifest splice from the prior flips. Test rework (same class): backend_registry enum-shorthand (sdl joins external), and the two build_zig sdl tests (wires-modules, input-core-override) point at a local sdl pkg + project_dir so the manifest splice resolves in-tree.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR changes how the ChangesSDL External Backend Resolution
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request extracts the sdl backend into an external package instead of keeping it bundled. It updates the backend registry tests, configures the sdl repository details in ProjectConfig, and updates the build tests to reference the external sdl package. There are no review comments, so no feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…386) (#448) sdl resolves out-of-tree now (`.backend = .sdl` → labelle-sdl, flipped in #447), so the in-tree backends/sdl/ slot is dead weight. Delete it + the coverage that built it in-tree: - Remove backends/sdl/ (src/templates/manifest/fragments/build_helpers/example). - CI: drop the "SDL backend build-helper tests" step. (backends/sdl_gamepad is a separate shared sub-package — still used by the bundled raylib/sokol — kept.) - Tests: drop the 2 sdl build_zig unit tests (no in-tree package to resolve; coverage moved to labelle-sdl's CI) + the sdl in-tree-template preview case. FOUR backends now fully out of the bundle: bgfx + wgpu + null + sdl. Remaining bundled: raylib, sokol.
builtinProvider(.sdl)→ labelle-sdl 0.1.0 — 4th default-external backend. Desktop-only, loop-style; inherits the cache fetch-path + splice from the prior flips. labelle-sdl published + CI-green. Test rework: enum-shorthand + the two sdl build_zig tests (local pkg + project_dir).zig build testgreen.Summary by CodeRabbit
New Features
Bug Fixes