fix(generate): empty pack (only pack.labelle) no longer breaks generate — Closes #590

[apotema]

Problem

A light pack shipping ONLY pack.labelle — no convention subdirs (components/, events/, prefabs/, hooks/, scripts/) and no verb files (queries.zig/commands.zig) — broke full generate().

Every scanPackSubdir call no-ops on its missing source (copyAndScanAbs tolerates a missing dir and returns an empty list), so scanPack never created <target>/packs/<name>/. The later writePackModuleRoots then hit a raw error.FileNotFound opening that dir to write __pack_root.zig.

Fix

Chose behavior (a): clean no-op — a pack.labelle-only light pack is legitimately allowed (light packs are module-less convention bundles). scanPack now creates its target pack dir up front, so an empty pack produces a valid, empty __pack_root.zig and generate() completes cleanly. No validation error needed.

Test

Adds a regression test in test/pack_scan_tests.zig (SCAN_PACK) that stages a pack.labelle-only pack, asserts scanPack returns empty scans + lays down the target dir, and reproduces the exact scanner.writeFile("packs/<name>/__pack_root.zig", …) seam that used to throw FileNotFound — now succeeds.

Verification

zig build test: 1482/1488 pass. The only failure is the pre-existing, unrelated flow_catalog.emitFlowCatalogSidecar test (shown twice, once per runner step).

https://claude.ai/code/session_017pW3ifKf9wgxNg4viy6okw

[coderabbitai]

Warning

Review limit reached

@apotema, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 49 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c001c551-94d5-41fe-b95d-bd3b79f35dff

📥 Commits

Reviewing files that changed from the base of the PR and between 38c8c67 and 922f409.

📒 Files selected for processing (2)

• src/root/pack_scan.zig
• test/pack_scan_tests.zig

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/590-empty-pack

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!