Run.get_* methods should open the HDF5 file in read-only mode - #71
Merged
philipstarkey merged 1 commit intoJun 25, 2020
Merged
Conversation
Fixes labscript-suite#42 Also addressed labscript-suite/labscript-utils#47 (removing h5py deprecation warnings) for this module Also fixed an issue where calling `set_group` on a `Run` inside a `Sequence` could disable the read-only mode of the `Run` object. Added `no_write` support to `Sequence`.
Member
Author
|
This is not tested at all (beyond check for syntax errors). Don't have time to do it today, or a set of data to analyse. Hoping one of you might - otherwise I'll see what I can dig out tomorrow. |
Member
Author
|
And the readthedocs webhook has vanished from GitHub settings? And I can't resync it from readthedocs dashboard either...why?!? |
rpanderson
approved these changes
Jun 24, 2020
Member
There was a problem hiding this comment.
Tested with runmanager → blacs → lyse using example_IMAQdx_remote.py (labscript-suite/labscript-utils#55), which uses Run.save_results.
Member
Author
|
@chrisjbillington Happy for me to merge? |
chrisjbillington
approved these changes
Jun 25, 2020
Member
|
Yep! |
philipstarkey
added a commit
that referenced
this pull request
Jun 25, 2020
commit f7a1427 Author: Phil Starkey <philipstarkey@users.noreply.github.com> Date: Thu Jun 25 19:03:31 2020 +1000 Update dependencies in setup.cfg Bumped runmanager and labscript_utils versions to `>=3.0.0` commit 20cb9af Merge: 74dfc19 2d8a80e Author: Phil Starkey <philipstarkey@users.noreply.github.com> Date: Thu Jun 25 12:56:40 2020 +1000 Merge pull request #71 from philipstarkey/philipstarkey/issue42 commit 2d8a80e Author: philipstarkey <philipstarkey@users.noreply.github.com> Date: Wed Jun 24 19:22:04 2020 +1000 Run.get_* methods should open the HDF5 file in read-only mode Fixes #42 Also addressed labscript-suite/labscript-utils#47 (removing h5py deprecation warnings) for this module Also fixed an issue where calling `set_group` on a `Run` inside a `Sequence` could disable the read-only mode of the `Run` object. Added `no_write` support to `Sequence`. commit 74dfc19 Merge: 1fc61cb 6cd5d06 Author: Russell Anderson <5637107+rpanderson@users.noreply.github.com> Date: Mon Jun 22 18:06:38 2020 +1000 Merge pull request #70 from philipstarkey/master fix docs conf bugs identified in labscript-suite/labscript-utils#57 commit 6cd5d06 Author: philipstarkey <philipstarkey@users.noreply.github.com> Date: Sat Jun 20 18:35:29 2020 +1000 fix docs conf bugs identified in labscript-suite/labscript-utils#57 commit 1fc61cb Merge: c6c2aa7 eed3f6e Author: Phil Starkey <philipstarkey@users.noreply.github.com> Date: Fri Jun 19 19:01:03 2020 +1000 Merge pull request #69 from philipstarkey/master Empty sphinx project following our template commit eed3f6e Author: philipstarkey <philipstarkey@users.noreply.github.com> Date: Fri Jun 19 18:30:22 2020 +1000 Empty sphinx project following our template commit c6c2aa7 Author: Russell Anderson <5637107+rpanderson@users.noreply.github.com> Date: Wed Jun 17 11:39:43 2020 +1000 Populated README.md with styling, iconogrpahy, prose, and badges commit 5760b8a Merge: bb2061d 84c6ec7 Author: Russell Anderson <5637107+rpanderson@users.noreply.github.com> Date: Tue Jun 16 12:07:02 2020 +1000 Merge pull request #68 from rpanderson/master experiment_name changed to apparatus_name commit 84c6ec7 Author: Russell Anderson <5637107+rpanderson@users.noreply.github.com> Date: Wed Jun 10 22:54:44 2020 +1000 experiment_name changed to apparatus_name Per labscript-suite/labscript-utils#53 Co-authored-by: chrisjbillington <chrisjbillington@gmail.com> Co-authored-by: Russell Anderson <5637107+rpanderson@users.noreply.github.com>
Loki27182
pushed a commit
to Loki27182/lyse
that referenced
this pull request
Oct 9, 2023
Ensure number of levels in the dataframe does not decrease.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42
Also addressed labscript-suite/labscript-utils#47 (removing h5py deprecation warnings) for this module
Also fixed an issue where calling
set_groupon aRuninside aSequencecould disable the read-only mode of theRunobject.Added
no_writesupport toSequence.