Logging level middleware - #2268
Closed
beykansen wants to merge 2 commits into
Closed
Conversation
added 2 commits
September 9, 2022 17:10
Contributor
|
Maybe using https://echo.labstack.com/middleware/logger/#customizable-function-based-requestlogger would make more sense? and you could start using proper logging library like https://github.com/rs/zerolog , https://github.com/uber-go/zap etc |
Contributor
|
I think this feature is covered now with #2341 This PR allows you to have custom tag with callback that can access context. so you can add anything you want to logger row - single or multiple tags etc. e.Use(middleware.LoggerWithConfig(middleware.LoggerConfig{
Format: `{"method":"${method}",${custom}}` + "\n",
CustomTagFunc: func(c echo.Context, buf *bytes.Buffer) (int, error) {
return buf.WriteString(`"tag":"my-value"`)
},
})) |
Contributor
|
As discussed we will close this in favor of #2341 which is already merged. Thanks though for this PR @beykansen and your thoughts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added
levelfield to logging template and allow customize withLevelSetterfunction for different use cases. For example, you can setleveltoinfoby just checkingerr == niland/or you can seterrorwhen request responded with500and/or
erroris not nil.Adding
levelfield to logs allows better filtering and observability in your log stack.