fix(secrets): redact key names and resolution paths from debug logs (issue #16) - #36
Merged
Conversation
…issue #16) Prevents CWE-532 — secret key names, env var names, and resolution paths are no longer logged at debug level. Missing-secrets warnings now show a count instead of listing individual key names, gated behind /verbose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CWE-532 (Insertion of Sensitive Information into Log File) — secret key names, env var names, and resolution paths were logged at debug level in secrets.ts and plugin-loader.ts. When /verbose is enabled, these logs expose the secret topology to all log consumers.
Changes
src/sdk/secrets.ts
src/agent/tools/plugin-loader.ts
src/sdk/tests/secrets.test.ts
Security Impact
Closes #16
🤖 Generated with Claude Code