docs(runner): add issue #26 references to orphan process prevention comments - #40
Merged
Merged
Conversation
…omments All four recommendations from issue #26 are already implemented in main: - detached: true removed - spawnedProcesses Set tracks all children - killAllSpawnedProcesses() called in stopAgent() and process.on('exit') - PR_SET_PDEATHSIG helper for Linux This commit adds code comments linking the implementation back to issue #26 for traceability. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #26 (orphan/detached bash subprocesses surviving agent death) is a duplicate of #24. All four recommendations from #26 were already implemented via PR #39 (now merged to main):
detached: trueremoved from spawn optionsspawnedProcessesSet, killed instopAgent()andprocess.on('exit')PR_SET_PDEATHSIGviabin/prctl-pdeathsig.chelper (Linux)child.kill()used instead ofprocess.kill(-pid)— works while parent is aliveThis PR adds code comments linking the implementation back to issue #26 for traceability.
Closes #26
🤖 Generated with Claude Code