fix(security): comprehensive security audit hardening (13 fixes) - #42
Merged
Conversation
Critical fixes: - C-4: Fix TOCTOU race in workspace validator (single atomic lstatSync) - C-1: Make wallet encryption mandatory (reject plaintext mnemonic save) - C-2: Encrypt plugin secrets at rest with AES-256-GCM - C-3: Fix exec tool allowlist bypass via shell metacharacter injection High fixes: - H-1/H-2/H-3/M-4: Harden media download (sanitize filenames, 50MB limit, 0o600 perms) - H-4: Add symlink re-checks in WebUI routes before write/delete/rename - H-6/H-7/H-8/H-9: Harden file/directory permissions (0o700 dirs, 0o600 files, COPYFILE_EXCL, skip symlinks) - H-10: Fix sandbox directory permissions (0o755 -> 0o700) Medium fixes: - M-1: Re-normalize path after recursive URL decode - M-2: Strengthen SVG CSP header - M-3: Restrict /read endpoint to safe file extensions - M-5: Document exec env whitelist priority Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security audit hardening: 13 fixes across workspace, wallet, secrets, exec, media, WebUI.
Critical: TOCTOU fix, mandatory wallet encryption, secrets encryption, exec sanitization.
High: media hardening, perms, symlink safety.
Medium: SVG CSP, read whitelist, URL normalization.
All 2928 tests pass. Lint clean.