Skip to content

chore(COD-4237): remove the hard-coded --secret option #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydubreil merged 1 commit into from
Jan 29, 2025
Merged

chore(COD-4237): remove the hard-coded --secret option #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ runs:
shell: bash
if: ${{ inputs.debug == 'true' }}
run: |
echo "LW_LOG=debug" >> $GITHUB_ENV
echo "LW_LOG=debug" >> $GITHUB_ENV
- if: steps.cache.outputs.cache-hit != 'true'
shell: bash
run: |
Expand Down
6 changes: 2 additions & 4 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import { error, getInput, info, setOutput, warning } from '@actions/core'
import { existsSync, appendFileSync } from 'fs'
import { appendFileSync, existsSync } from 'fs'
import {
downloadArtifact,
postCommentIfInPr,
resolveExistingCommentIfFound,
uploadArtifact,
} from './actions'
import { downloadKeys, trustedKeys } from './keys'
import { compareResults, createPRs, printResults } from './tool'
import {
autofix,
Expand All @@ -15,12 +16,10 @@ import {
getActionRef,
getMsSinceStart,
getOptionalEnvVariable,
getOrDefault,
getRequiredEnvVariable,
getRunUrl,
telemetryCollector,
} from './util'
import { downloadKeys, trustedKeys } from './keys'

const scaSarifReport = 'scaReport/output.sarif'
const scaReport = 'sca.sarif'
Expand Down Expand Up @@ -60,7 +59,6 @@ async function runAnalysis() {
'ci',
'--keyring',
trustedKeys,
'--secret',
Copy link
Contributor Author

@jeremydubreil jeremydubreil Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only line changed by the PR. The rest is pre-existing auto-formatting issues.

]
if (indirectDeps.toLowerCase() === 'false') {
args.push('--eval-direct-only')
Expand Down