Skip to content

feat(example): add generated dataset fallback for ivf_hnsw example#6925

Open
jiengup wants to merge 2 commits into
lance-format:mainfrom
jiengup:example/ivf-hnsw-fallback
Open

feat(example): add generated dataset fallback for ivf_hnsw example#6925
jiengup wants to merge 2 commits into
lance-format:mainfrom
jiengup:example/ivf-hnsw-fallback

Conversation

@jiengup
Copy link
Copy Markdown
Contributor

@jiengup jiengup commented May 23, 2026

Summary

  • Make the ivf_hnsw example dataset URI optional
  • Generate a temporary local Lance dataset when no URI is provided
  • Ensure generated vector column uses FixedSizeList<Float32, 64> so it can build a vector index
  • Wire CLI HNSW params into HnswBuildParams

Testing

  • `cargo check -p lance-examples --example ivf_hnsw

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-actions github-actions Bot added the enhancement New feature or request label May 23, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant