Skip to content

style: some cleanup #33857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdrxy merged 2 commits into from
Nov 7, 2025
Merged

style: some cleanup #33857

mdrxy merged 2 commits into from
Nov 7, 2025

Conversation

@mdrxy
Copy link
Member

@mdrxy mdrxy commented Nov 7, 2025

No description provided.

@mdrxy mdrxy requested review from ccurme and eyurtsev as code owners November 7, 2025 04:45
@github-actions github-actions bot added security integration PR made that is related to a provider partner package integration core `langchain-core` package issues & PRs langchain `langchain` package issues & PRs standard-tests Related to the package `standard-tests` text-splitters Related to the package `text-splitters` dependencies Pull requests that update a dependency file (e.g. `pyproject.toml` or `uv.lock`) v1 Issue specific to LangChain 1.0 labels Nov 7, 2025
@mdrxy mdrxy merged commit e023201 into master Nov 7, 2025
232 checks passed
@mdrxy mdrxy deleted the mdrxy/cleanupp branch November 7, 2025 04:50
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 7, 2025

CodSpeed Performance Report

Merging #33857 will not alter performance

Comparing mdrxy/cleanupp (64cadf6) with master (d40e340)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 29 untouched
⏩ 5 skipped1

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ccurme ccurme Awaiting requested review from ccurme ccurme is a code owner

@eyurtsev eyurtsev Awaiting requested review from eyurtsev eyurtsev is a code owner

Assignees

No one assigned

Labels

core `langchain-core` package issues & PRs dependencies Pull requests that update a dependency file (e.g. `pyproject.toml` or `uv.lock`) integration PR made that is related to a provider partner package integration langchain `langchain` package issues & PRs standard-tests Related to the package `standard-tests` text-splitters Related to the package `text-splitters` v1 Issue specific to LangChain 1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdrxy