fix(cli): remove access to private asyncio internals in monitor_stream #6609
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the use of private asyncio internals (
_bufferattribute and_maybe_resume_transport()method) from themonitor_stream()function inlibs/cli/langgraph_cli/exec.py.Problem
The current implementation directly accesses
asyncio.StreamReader._bufferand calls_maybe_resume_transport()when handlingLimitOverrunError. These are private implementation details that:# type: ignorecomments due to accessing private membersSolution
Refactored the
LimitOverrunErrorhandling to use only public asyncio APIs:_bufferaccess withstream.read(e.consumed)to read available data_maybe_resume_transport()call (handled automatically by public read methods)LimitOverrunErrorhandling for edge casesBenefits
# type: ignorecommentsIssue
Fixes potential breakage in future Python versions where asyncio internals may change.
Dependencies
None - uses only standard library asyncio public APIs.
Testing
_bufferor_maybe_resume_transportremain in the codebase