Add 'danger' method to match bootstrap class#158
Closed
danswiser wants to merge 2 commits intolaracasts:masterfrom
danswiser:patch-1
Closed
Add 'danger' method to match bootstrap class#158danswiser wants to merge 2 commits intolaracasts:masterfrom danswiser:patch-1
danswiser wants to merge 2 commits intolaracasts:masterfrom
danswiser:patch-1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are four "standard" bootstrap alert classes in addition to the other less standard alerts. The four "proper" alert types are success, info, warning and danger. The
alert-dangerclass does not match the->error()method name like the other methods do. This leads to confusing behavior.The original
->error()method remains unchanged for backwards compatibility.