[5.8] in/not in operators

[jerguslejko]

This PR introduces the ability to pass in or not in strings as an operator to the query builder.

// these two calls produce the same query
$query->where('foo', 'in', [1, 2]);
$query->whereIn('foo', [1, 2]);

// these two calls produce the same query
$query->where('foo', 'not in', [1, 2]);
$query->whereNotIn('foo', [1, 2]);

The reasons behind this PR:

• being able to pass-in these strings as operators allows for nicer query generation:

  [$name, $operator, $value] = $filter->get(); // Filter model stored in the database
  
  // This PR allows for this
  $query->where($name, $operator, $value);
  
  // Instead of this
  if ($operator == 'in') {
      $query->whereIn($name, $value);
  } else if ($operator == 'not in') {
      $query->whereNotIn($name, $value);
  } else {
      $query->where($name, $operator, $value);
  }

• in the current implementation, it is kind of unintuitive that $query->where('foo', 'in', [1, 2]) produces where foo = "in"

Thanks for reviewing this.

[donnysim]

What will happen if you do $query->where('direction', 'in') etc.? Like you're aiming for direction = 'in'?

[jerguslejko]

@donnysim if the where method is called with 2 arguments, the = operator is assumed.

Therefore, $query->where('direction', 'in') will generate direction = 'in'

[donnysim]

Is there a test for such case? It would feel safer if there is one in case someone tampers further with it in the future, but I do like this change 👍

[jerguslejko]

@donnysim this is the same issue as doing $query->where('foo', '=') - I want all rows where the foo field has an equal sign in it. This is already handled by the framework

[ahinkle]

I don't think we should over complicate the query builder with multiple different types of syntax operations. The merging of this opens the door for many more PRs with alternative constructors.

[jerguslejko]

@ahinkle the query builder already supports this type of querying. $query->where('foo', 'like', '%a%') works this way

[ahinkle]

Yes, we don't have a whereLike; as opposed to the already existing whereIn.

[jerguslejko]

@ahinkle let's wait and see what @taylorotwell thinks

[bonzai]

#15219
#15266

[jerguslejko]

thanks taylor

[Cannonb4ll]

Please see referenced issue and PR, this PR is completely breaking withPivot(), I also fail to see how this is helpful in any way since we already had the explicit whereIn() and whereNotIn() methods.

[duxthefux]

it also uses weak == comparison which breaks the case ->where("col", true) and ->where("col", false)...took me an hour to debug this. Why are people using == instead of ===...

 >>> 'in'==0
=> true

'>>> 'in'==true
=> true

[decadence]

Reverted here: 04a547e