[5.8] Fix the remaining issues with registering custom Doctrine types.#28375
Merged
taylorotwell merged 2 commits intolaravel:5.8from May 1, 2019
jensdenies:fix-registering
Merged
[5.8] Fix the remaining issues with registering custom Doctrine types.#28375taylorotwell merged 2 commits intolaravel:5.8from jensdenies:fix-registering
taylorotwell merged 2 commits intolaravel:5.8from
jensdenies:fix-registering
Conversation
|
If support for tinyint is being removed from core Laravel, does the documentation ned to be updated to remove references to tinyIncrements , tinyInteger, and unsignedTinyInteger? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the TinyInteger type from the core and allows the user to register their own custom Doctrine DBAL types. No connection wil be established by only instantiating the builder class, only as soon as you call the registerCustomDoctrineType method. Therefore it won't cause issues like #28282 anymore.