[5.8] Provide notification callback with Swift message#28535
Merged
taylorotwell merged 1 commit intolaravel:5.8from May 15, 2019
Merged
[5.8] Provide notification callback with Swift message#28535taylorotwell merged 1 commit intolaravel:5.8from
taylorotwell merged 1 commit intolaravel:5.8from
Conversation
|
Hi, The Laravel 8.X documentation about Notifications doesn't indicate we can use the SwiftMessage callback as one'd do with Mail :-) : https://laravel.com/docs/8.x/notifications#formatting-mail-messages Best regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an improved approach to #28534 which provides developers direct access to the underlying Swift message before it is fired off. The use-case for the earlier PR was to allow adding headers to the message (for tracking/analytics) but this is a more flexible solution with greater control.
In addition, this approach mimics
withSwiftMessage($callback)which mailables have, so it should be familiar for people who are already using that for those reasons. As mentioned in the other PR there has been chatter about supporting custom headers for notification mail (laravel/ideas#475) and this provides that functionality.