[5.8] Add app()->isProduction helper and tests#28602
Merged
taylorotwell merged 2 commits intolaravel:5.8from May 24, 2019
jasonlbeggs:jlb-add-app-is-production
Merged
[5.8] Add app()->isProduction helper and tests#28602taylorotwell merged 2 commits intolaravel:5.8from jasonlbeggs:jlb-add-app-is-production
taylorotwell merged 2 commits intolaravel:5.8from
jasonlbeggs:jlb-add-app-is-production
Conversation
jasonlbeggs
changed the title
Contributor
|
Do you think it's helpful to support environment aliases? For example, if I experience one case in Symfony Framework. I have to use dev, test and prod environments. Some developers may prefer these values. But if these aliases are used in Laravel, all methods isProduction(), isLocal() and runningUnitTests() don't work properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an
isProduction()helper to match theisLocalandrunningUnitTestshelpers as these are the most common environments in use.I also added tests for those three methods.