Skip to content

[5.8] Fix dynamodb cache forever method #28618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taylorotwell merged 1 commit into from
May 26, 2019
Merged

[5.8] Fix dynamodb cache forever method #28618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix dynamodb cache forever method 
Convert the expiry to an integer timestamp for comparison
  • Loading branch information
jradtilbrook committed May 26, 2019
commit e9d0f5ecccaffc328dfb2e4b7f1cc132cd64cdf6
2 changes: 1 addition & 1 deletion src/Illuminate/Cache/DynamoDbStore.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ public function decrement($key, $value = 1)
*/
public function forever($key, $value)
{
return $this->put($key, $value, now()->addYears(5));
return $this->put($key, $value, now()->addYears(5)->getTimestamp());
}

/**
Expand Down