[5.8] Fix event:list command#28624
Merged
taylorotwell merged 1 commit intolaravel:5.8from May 27, 2019
joedixon:fix-event-list
Merged
[5.8] Fix event:list command#28624taylorotwell merged 1 commit intolaravel:5.8from joedixon:fix-event-list
taylorotwell merged 1 commit intolaravel:5.8from
joedixon:fix-event-list
Conversation
Member
|
Isn't it weird that the |
Contributor
Author
|
Well, I think it’s probably expected behaviour. If I add it to the $listen array and have auto discovery on, my listener fires twice. I assume it’s the developers responsibility not to list it there and use auto discovery? |
Member
|
@joedixon ah, if it's fired twice than that definitely makes sense. I can follow that reasoning 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a combination of manually registering events in the
EventServiceProviderand event auto discovery, the output ofphp artisan event:listcan be unexpected.Example
If I have two listeners in the
app/Listenersdirectory for theVoteWasCastevent (e.g.StoreVoteandSendVote), but I only have one of those manually registered in theEventServiceProvideras below, I would still expect both to be included in the output ofphp artisan event:list.However, below is the output I get:
This PR provides the following output which is in line with what I would expect.