[5.8] Fix database rules with WHERE clauses#28748
Merged
taylorotwell merged 1 commit intolaravel:5.8from Jun 6, 2019
staudenmeir:database-rule
Merged
[5.8] Fix database rules with WHERE clauses#28748taylorotwell merged 1 commit intolaravel:5.8from staudenmeir:database-rule
taylorotwell merged 1 commit intolaravel:5.8from
staudenmeir:database-rule
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
existsanduniquerules fail if aWHEREclause has an empty string value:This throws an exception:
The error is caused by
rtrim(..., , ',')inExists::__toString():The underlying issue is that
ValidationRuleParser::parseParameters()parses parameters as CSV, but only receives plain text. This also affects values that can be interpreted as CSV:We can fix it by converting all values to CSV as we do with
inandnotinrules (#21012).Fixes #28697.
Theoretically, this can be a breaking change if someone works around the issue by providing CSV values:
Do we consider cases like this?