[5.8] Add message value assertion to assertJsonValidationErrors#28787
Merged
taylorotwell merged 1 commit intolaravel:5.8from Jun 11, 2019
ahinkle:assertJsonValidationError
Merged
[5.8] Add message value assertion to assertJsonValidationErrors#28787taylorotwell merged 1 commit intolaravel:5.8from ahinkle:assertJsonValidationError
taylorotwell merged 1 commit intolaravel:5.8from
ahinkle:assertJsonValidationError
Conversation
Member
|
@ahinkle I shipped an augmentation to this method so that it handles arrays of error messages for a single key:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmit of #27655.
This PR adds the assertion for JSON validation error messages in
assertJsonValidationErrors.Currently, we can only check json validation error keys:
$this->assertJsonValidationErrors('key');$this->assertJsonValidationErrors(['foo', 'bar']);With this addition, you will be able to check the key and the message:
$this->assertJsonValidationErrors(['key' => 'validation message']);You can still continue to use the normal functionality by just passing a key, array of keys, or a mix of each.