[5.8] allow view assertions to see all data#28893
Merged
taylorotwell merged 1 commit intolaravel:5.8from Jun 20, 2019
browner12:assert-view
Merged
[5.8] allow view assertions to see all data#28893taylorotwell merged 1 commit intolaravel:5.8from browner12:assert-view
taylorotwell merged 1 commit intolaravel:5.8from
browner12:assert-view
Conversation
currently, the view assertions can only see data passed directly to the view. this change allows the assertions to also see the data that has been 'shared'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
assertViewHas()assertion in the HTTP testing will currently only look at data bound directly to the view, and not data that has been 'shared' with the view. This makes it a little clunkier to check for shared data.Solution
The view assertions now use the
gatherData()method, instead of thegetData()method, which provides us both the directly bound data, and the globally shared data.Concerns
assertViewHasShared()or something similar?