Skip to content

[5.8] Read an optional mix asset url from MIX_ASSET_URL env variable#28952

Merged
taylorotwell merged 4 commits intolaravel:5.8from
themsaid:pr/4237
Jun 26, 2019
Merged

[5.8] Read an optional mix asset url from MIX_ASSET_URL env variable#28952
taylorotwell merged 4 commits intolaravel:5.8from
themsaid:pr/4237

Conversation

@themsaid
Copy link
Copy Markdown
Member

No description provided.

@GrahamCampbell GrahamCampbell changed the title Read an optional mix asset url from MIX_ASSET_URL env variable [5.9] Read an optional mix asset url from MIX_ASSET_URL env variable Jun 25, 2019
@GrahamCampbell GrahamCampbell changed the title [5.9] Read an optional mix asset url from MIX_ASSET_URL env variable [5.8] Read an optional mix asset url from MIX_ASSET_URL env variable Jun 25, 2019
@danilopinotti
Copy link
Copy Markdown
Contributor

danilopinotti commented Jun 25, 2019

When caching the configs by artisan command, the env helper does not always return null?
I believe the most ideal is to put this 'namespace' in a configuration file where it uses the env helper

@themsaid
Copy link
Copy Markdown
Member Author

@danilopinotti thanks, did that :)

@X-Coder264
Copy link
Copy Markdown
Contributor

IMO, there should be tests for when the repository actually returns some value for the app.mix_url key. Currently all the mock ensures is that the get method gets called with the proper key (but it doesn't return anything).

@laurencei
Copy link
Copy Markdown
Contributor

laurencei commented Jun 26, 2019

Does it have to go into the app.php config file? That is rapidly becoming a "dump all" place to put things.

Wouldnt the view.php config file make more sense in this case? or even create a mix.php file for this plus any future mix related config items?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants