[5.8] Pass down the serverVersion database connection option to Doctrine DBAL connection#28964
Merged
taylorotwell merged 1 commit intolaravel:5.8from Jun 27, 2019
tonysm:fix-migration-and-serverVersion
Merged
[5.8] Pass down the serverVersion database connection option to Doctrine DBAL connection#28964taylorotwell merged 1 commit intolaravel:5.8from tonysm:fix-migration-and-serverVersion
taylorotwell merged 1 commit intolaravel:5.8from
tonysm:fix-migration-and-serverVersion
Conversation
…AL connection I got into this issue when I was trying to run the migrations against Azure's MySQL database. Azure's setup uses a gateway [1] to proxy connections to the correct server, which tricks PDO, because the gateway version is different than the actual server that the migration runs is 5.7, while the gateway server runs a 5.6. By using this option, we can manually pass the server version (5.7) and the correct data types will be mapped. In my case, JSON columns were throwing exception, even though they are supported in the actual server [2]. References: [1](https://docs.microsoft.com/en-us/azure/mysql/concepts-supported-versions) [2](https://www.doctrine-project.org/projects/doctrine-dbal/en/2.9/reference/configuration.html#automatic-platform-version-detection)
tonysm
changed the title
Contributor
Author
|
Would love to get this on Laravel 5.7.x as well, how can I make it? Should I send another PR to 5.7? |
Member
|
@tonysm 5.7 isn't supported anymore unfortunately: https://laravel.com/docs/5.8/releases#support-policy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got into this issue while I was trying to run the migrations against Azure's MySQL
database. Azure's setup uses a gateway to proxy connections to the correct server,
which tricks PDO, because the gateway version is different than the actual server
that the migration runs. The server runs 5.7, while the gateway server runs a 5.6.
By using this option, we can manually pass the server version (5.7) and the correct
data types will be mapped. In my case, JSON columns were throwing an exception, even
though they are supported in the actual server.