feat(apps): add miaoda apps domain (6 shortcuts + dry-run e2e)#1002
Merged
Conversation
|
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds the Miaoda "apps" domain with six CLI shortcuts, HTML publish tooling (walker, tarball, client), env override for Open API base, local mock/test infra and scripts, extensive unit and dry-run E2E tests, and documentation. ChangesMiaoda Apps Domain
Estimated code review effort 🎯 4 (Complex) | ⏱️ ~60 minutes Suggested labels
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests (beta)
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has checked 1604 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 1149 | 2 | 453 | 0 |
Click to see the invalid file list
- cmd/_apps_dev_tools/inject_scopes/main.go
- scripts/apps-mock.py
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1002 +/- ##
==========================================
+ Coverage 65.92% 67.73% +1.81%
==========================================
Files 523 586 +63
Lines 49692 54823 +5131
==========================================
+ Hits 32758 37135 +4377
- Misses 14134 14598 +464
- Partials 2800 3090 +290 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@203e2e33150031eddd7e3c75ccf40dc288582da2🧩 Skill updatenpx skills add larksuite/cli#feat/apps-domain -y -g |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 14
🧹 Nitpick comments (1)
shortcuts/apps/apps_html_publish_test.go (1)
31-35: ⚡ Quick winDon’t ignore fixture write errors in tests.
These fixture writes currently discard errors, which can hide setup failures and create misleading test outcomes. Please assert
os.WriteFileerrors consistently.Also applies to: 127-128, 142-142, 161-161
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@shortcuts/apps/apps_html_publish_test.go` around lines 31 - 35, The test helper writeAppsSampleSite currently ignores the os.WriteFile error; update it to capture the returned error from os.WriteFile and fail the test on error (e.g., if err != nil { t.Fatalf("write fixture: %v", err) }) so setup failures surface; apply the same change to the other fixture writes flagged in this file (the other os.WriteFile calls around the same helper/test helpers) to consistently assert write errors.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cmd/_apps_dev_tools/inject_scopes/main.go`:
- Around line 56-59: The status messages currently printed with fmt.Printf ("OK:
injected %d..." and each extra scope) are sent to stdout and must be moved to
stderr to preserve stdout as the data channel; update the prints in main.go (the
block that uses variables added, out and iterates over extra) to write to
os.Stderr (e.g., use fmt.Fprintf or fmt.Fprintln with os.Stderr) so all
human-readable progress/warnings go to stderr while leaving stdout untouched.
In `@scripts/apps-mock.py`:
- Around line 72-77: The lines in the request handler use semicolon-chained
statements which trip Ruff E702; replace each chained sequence with one
statement per line: split occurrences like "self.send_response(404);
self.end_headers(); return", "self.send_header('Content-Type', 'text/plain');
self.end_headers(); self.wfile.write(raw); return", and
"self.send_header('Content-Type', 'application/json'); self.end_headers()" into
separate lines so each call (self.send_response, self.end_headers, return,
self.send_header, self.wfile.write) appears on its own line around the
build_response(action) call and subsequent response handling.
In `@shortcuts/apps/apps_access_scope_set.go`:
- Around line 92-101: In the "public" branch of the scope switch in
apps_access_scope_set.go, add validation to reject a provided approver: if scope
== "public" and the approver flag/variable (approver) is non-empty, return
output.ErrValidation("--approver is not allowed when --scope=public"); this
should sit alongside the existing checks for targets and applyEnabled so the CLI
fails early instead of silently dropping approver when building the request
body.
In `@shortcuts/apps/apps_update.go`:
- Around line 43-49: The API path is built from the raw flag value
rctx.Str("app-id") without trimming, so values like " app_x " become encoded
with spaces; update both the PATCH builder and the Execute path construction to
trim the app-id before encoding (use strings.TrimSpace(rctx.Str("app-id")) or
equivalent) where validate.EncodePathSegment(...) is called (affecting the
PATCH(...) call and the path variable in Execute), ensuring
buildAppsUpdateBody(rctx) use remains unchanged.
In `@shortcuts/apps/html_publish_tarball_test.go`:
- Around line 105-128: The test TestWriteHTMLPublishTarEntry_CopyFailure should
avoid chmod-based flakes and instead inject a deterministic failing reader:
modify the test to use a stub implementation of fileio.FileIO/fileio.File (the
same interfaces used by newTestFIO()) whose Open returns a File whose Read (or
ReadFrom/ReadAt used by io.Copy) returns a specific error; call
writeHTMLPublishTarEntry with that stubbed FIO and the same htmlPublishCandidate
(RelPath/AbsPath/Size) and assert the returned error contains the expected
message (e.g., contains "read" or your stub error), removing the
os.Chmod/permission manipulation and relying on the injected failing File to
trigger the io.Copy error path.
In `@shortcuts/apps/walk_html_publish_candidates.go`:
- Around line 43-58: The current loop appends any non-directory entry (including
symlinks) to out as an htmlPublishCandidate; update the check before appending
to only include regular files by using info.Mode().IsRegular() and explicitly
skip entries where info.Mode()&os.ModeSymlink != 0 (or use ModeSymlink) so
symlinks and other non-regular entries are not added; ensure this check is
applied right before creating htmlPublishCandidate (which sets RelPath, AbsPath,
Size) using the existing rel and info values.
In `@skills/lark-apps/references/lark-apps-access-scope-set.md`:
- Line 30: The table cell JSON example {"type":"user|department|chat",
"id":"<id>"} contains unescaped pipe characters which break Markdown table
rendering; update that cell to escape the pipes (e.g., replace
user|department|chat with user\|department\|chat or use the HTML entity &`#124`;
for the pipes) so the table parses correctly while keeping the rest of the JSON
unchanged.
In `@skills/lark-apps/references/lark-apps-html-publish.md`:
- Line 109: The example command "lark-cli apps +html-publish --path ./dist
--dry-run" is missing the required --app-id flag; update the example to include
--app-id (e.g. --app-id <your-app-id>) so the documented dry-run command
validates and runs correctly, and ensure the text around it notes that --app-id
is mandatory.
In `@tests/cli_e2e/apps/apps_access_scope_get_dryrun_test.go`:
- Line 55: The test currently asserts the validation message only against
result.Stderr (assert.Contains(t, result.Stderr, ...)) which is brittle; update
the assertion to check the combined output (result.Stdout + result.Stderr)
instead and ensure the test also asserts a non-zero exit code for the dry-run
validation failure, referencing the existing assert.Contains usage and the
result.Stdout/result.Stderr variables to locate where to change the check.
In `@tests/cli_e2e/apps/apps_access_scope_set_dryrun_test.go`:
- Line 133: The assertions currently inspect only result.Stderr using
gjson.Get(result.Stderr, "error.message"), which is fragile for dry-run
Validate-stage failures; update these to parse the combined output by using
gjson.Get(result.Stdout+result.Stderr, "error.message") (replace occurrences of
gjson.Get(result.Stderr, ...) in this file), and make the same change at the
other mentioned assertion sites (around the instances flagged at lines 152, 171,
191) so the tests assert against result.Stdout+result.Stderr and still check for
the "--targets is required" message and non-zero exit.
In `@tests/cli_e2e/apps/apps_create_dryrun_test.go`:
- Around line 91-167: The three subtests ("RejectsBlankName",
"RejectsInvalidAppType", "RejectsLowercaseAppType") are asserting only non-zero
exit and reading the validation envelope from result.Stderr; update each to
assert exit code == 2 and read the structured validation error from
result.Stdout (use gjson.Get(result.Stdout, "error.message").String()), falling
back to result.Stderr only if Stdout is empty, keeping the same assertion on the
message content; modify the assertions that currently use result.Stderr and
assert.NotEqual(t, 0, result.ExitCode) to use result.Stdout and assert.Equal(t,
2, result.ExitCode) when appropriate.
In `@tests/cli_e2e/apps/apps_html_publish_dryrun_test.go`:
- Around line 183-185: Update the dry-run validation assertions to match repo
convention: replace the non-zero exit assertion with assert.Equal(t, 2,
result.ExitCode) and check the combined output string by asserting the error
text is in result.Stdout+result.Stderr instead of only result.Stderr; apply the
same change for the other occurrence in the same test file that validates
required-flag failure (uses variables result, result.ExitCode, result.Stdout and
result.Stderr).
In `@tests/cli_e2e/apps/apps_update_dryrun_test.go`:
- Around line 83-99: The test in t.Run("RejectsNoFields") reads the validation
envelope from result.Stderr and only asserts a non-zero exit code; change it to
assert the dry-run validation convention by expecting result.ExitCode == 2 and
parse the validation JSON from result.Stdout (falling back to result.Stderr only
if stdout is empty) when extracting error.message with gjson.Get; update the
assertions in this test (function name RejectsNoFields, variables result and
msg) accordingly.
In `@tests/cli_e2e/apps/coverage.md`:
- Around line 18-21: Add one empty line before the "## Command Table" table
block and one empty line after the table block in the markdown (the table
beginning with the header row "| Status | Cmd | Type | Testcase | Key parameter
shapes | Notes / uncovered reason |") so the markdown has a blank line
separating the table from surrounding content to satisfy MD058.
---
Nitpick comments:
In `@shortcuts/apps/apps_html_publish_test.go`:
- Around line 31-35: The test helper writeAppsSampleSite currently ignores the
os.WriteFile error; update it to capture the returned error from os.WriteFile
and fail the test on error (e.g., if err != nil { t.Fatalf("write fixture: %v",
err) }) so setup failures surface; apply the same change to the other fixture
writes flagged in this file (the other os.WriteFile calls around the same
helper/test helpers) to consistently assert write errors.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a492d77c-8603-4bbd-98e4-49ebbf6af38d
📒 Files selected for processing (44)
cmd/_apps_dev_tools/inject_scopes/main.gointernal/cmdutil/factory_default.gointernal/core/types.gointernal/core/types_test.goscripts/apps-mock.pyscripts/apps-test-env.shshortcuts/apps/apps_access_scope_get.goshortcuts/apps/apps_access_scope_get_test.goshortcuts/apps/apps_access_scope_set.goshortcuts/apps/apps_access_scope_set_test.goshortcuts/apps/apps_create.goshortcuts/apps/apps_create_test.goshortcuts/apps/apps_html_publish.goshortcuts/apps/apps_html_publish_test.goshortcuts/apps/apps_list.goshortcuts/apps/apps_list_test.goshortcuts/apps/apps_update.goshortcuts/apps/apps_update_test.goshortcuts/apps/common.goshortcuts/apps/html_publish_client.goshortcuts/apps/html_publish_client_test.goshortcuts/apps/html_publish_tarball.goshortcuts/apps/html_publish_tarball_test.goshortcuts/apps/shortcuts.goshortcuts/apps/shortcuts_test.goshortcuts/apps/walk_html_publish_candidates.goshortcuts/apps/walk_html_publish_candidates_test.goshortcuts/register.goskill-template/domains/apps.mdskills/lark-apps/SKILL.mdskills/lark-apps/references/lark-apps-access-scope-get.mdskills/lark-apps/references/lark-apps-access-scope-set.mdskills/lark-apps/references/lark-apps-create.mdskills/lark-apps/references/lark-apps-html-publish.mdskills/lark-apps/references/lark-apps-list.mdskills/lark-apps/references/lark-apps-update.mdtests/cli_e2e/apps/apps_access_scope_get_dryrun_test.gotests/cli_e2e/apps/apps_access_scope_set_dryrun_test.gotests/cli_e2e/apps/apps_create_dryrun_test.gotests/cli_e2e/apps/apps_html_publish_dryrun_test.gotests/cli_e2e/apps/apps_list_dryrun_test.gotests/cli_e2e/apps/apps_update_dryrun_test.gotests/cli_e2e/apps/coverage.mdtests/cli_e2e/apps/helpers_test.go
raistlin042
added a commit
that referenced
this pull request
May 21, 2026
CI failures ----------- - license-header: add SPDX/Apache header to the two new files that were missing it (scripts/apps-mock.py, cmd/_apps_dev_tools/inject_scopes/main.go). - security/gitleaks: the cursor example in lark-apps-list.md tripped the generic-api-key rule because its base64-ish value had entropy > 4.3. Swap for a low-entropy placeholder `cursor_next_xxx`; same content, no fake-secret signal. Real bugs surfaced in review ---------------------------- - apps +access-scope-set: --scope=public was silently dropping --approver if the user passed it. Add the missing mutex check so Validate rejects it consistently with the other public-mode flag conflicts. - apps +update: --app-id was URL-encoded without TrimSpace, so a value like " app_x " would land in the request path with literal spaces. The rest of the apps shortcuts already trim; bring update in line. - walker: only accept regular files. Symlinks, devices, sockets are skipped — symlink-not-followed was already the design intent (avoid loops + out-of-root escapes) but the walker was silently appending the symlink entry itself, which the downstream fio.Open would reject later. Filter at walk time and update the symlink test to assert the link is absent from the manifest. - inject_scopes dev tool: status messages went to stdout, violating the AGENTS.md "stdout=data" contract. Redirect to stderr so a future caller can rely on stdout being silent. Style + docs nits ----------------- - apps-mock.py: split Ruff E702 semicolon chains in the response writer. - lark-apps-access-scope-set.md: escape pipes in the targets JSON cell so the markdown table renders. - lark-apps-html-publish.md: example command was missing required --app-id flag. - tests/cli_e2e/apps/coverage.md: MD058 (blank line around table). Test improvements ----------------- - TestWriteHTMLPublishTarEntry_CopyFailure no longer uses chmod 0o000 (flaky as root / on some filesystems). Inject a fileio.File stub whose Read returns a synthetic error so the io.Copy failure branch fires deterministically. - e2e dryrun JSON-envelope assertions now read result.Stdout + result.Stderr instead of only Stderr. Different shortcut families in the repo land the dry-run validation envelope on different channels (markdown / drive_search write to stdout + exit 0; apps writes to stderr + exit non-zero). Concatenating lets the assertion succeed in either contract so the tests don't accidentally pin the runner-internal choice. Plain cobra `required flag(s)` text checks stay on Stderr — that one always goes to stderr.
Adds the apps package with AppsCreate shortcut (POST /open-apis/miaoda/v1/apps) and reusable test helpers (newAppsExecuteFactory/runAppsShortcut) for Tasks 2.2–2.4/3.4.
Implements PUT /apps/{appId}/access-scope with three scope branches
(specific/public/tenant), mutual-exclusion validation, and JSON target
type enforcement. 7 new tests all pass.
Implements appsHTMLPublishClient interface and appsHTMLPublishAPI that POSTs multipart/form-data to upload_and_release_html_code with field name 'file', parses the JSON envelope, and maps business error codes to hinted ExitErrors.
Wires walker + tarball + HTTP client into runHTMLPublish; adds 20MB size precheck via mutable package var maxHTMLPublishTarballBytes; defer cleanup is registered before size check so reject path never leaks temp files.
- skills/lark-apps/SKILL.md: handwritten for Agent discovery (gen-skills tool not in this repo yet) - docs/dev/miaoda-local-dev.md: bulk-replace lark-miaoda → lark-apps, shortcuts/miaoda → shortcuts/apps, +publish-html → +html-publish. Preserved: scope strings (miaoda:app:*), URL prefix (/open-apis/miaoda/v1/*), BOE env names (boe_miaoda_*), pkg names (miaoda-qa-*), brand mention.
BOE 端目前以 spark 系列注册： - OAPI base path: /open-apis/spark/v1 (replaces /miaoda/v1) - Scope: spark:app.table:write (replaces miaoda:app:write / readonly / deploy) Reverts pending: 待后端 /open-apis/miaoda/v1 + miaoda:app:* 注册稳定后切回。 Affected: 5 shortcuts (apps_create / apps_update / apps_list / apps_access_scope_set / apps_html_publish) + apiBasePath constant.
之前用 spark:app.table:write 作为临时 placeholder（绕过 client 端 scope check）。 后端 BOE 现在正式注册了 5 个 scope，按 shortcut 职责更新： +create / +update → spark:app:write +list → spark:app:read +access-scope-set → spark:app.access_scope:write +html-publish → spark:app:publish 意义：让客户端预检 + auth login hint 指向真实可授权的 scope，避免 "明明授权了还报 missing_scope" 的混淆体验。
- broaden description to cover "用 HTML 开发 PPT / 可演示 demo / 部署成 可分享网站" phrasing so the skill fires when users describe building HTML presentations or asking lark-cli to deploy a folder - add end-to-end workflow table (create -> publish -> optional access-scope) so the agent finishes the publish chain instead of stopping at "HTML 写好了" - default to apps +create on a missing app_id; only fall back to +list when the user explicitly references an existing app - realign overall structure with skills/lark-doc/SKILL.md (常用示例 / 前置条件 / 快速决策 / Shortcuts) and drop the unused version field
…ot explicit publish
Split the publish decision into two intent buckets:
- Explicit publish/share ("部署 ./xxx", "发布到妙搭", "部署成可分享的
网站"): keep the auto-publish behavior, no prompt.
- Presentation-only ("写一个可演示的 PPT", "做个 demo", no mention of
deploy / share / URL): emit the local HTML first, then ASK the user
whether to publish before invoking apps +html-publish.
Rewrite the end-to-end workflow as a two-step decision: (1) classify the
user's intent against the new lookup table; (2) only run the publish
chain after intent is confirmed. Mirror the same split in 快速决策 and
in the Shortcuts table's +html-publish row.
…plit arrays)
后端可用范围接口契约升级：
- scope: string "specific/public/tenant" → int 枚举（1=All / 2=Tenant / 3=Range）
- targets: 统一数组 [{type,id}] → 拆 users / departments / chats 三个并列字符串数组
CLI 用户接口保持稳定（仍写 --scope specific --targets '[{type:user,id:xxx}]'），
buildAccessScopeBody 内部做映射 + 分组，对 Agent / 用户透明。
同时补 commit 3355a3a 的遗留：测试文件里硬编码的 stub URL 从
/open-apis/miaoda/v1 → /open-apis/spark/v1 同步（之前没显式跑单测发现）。
妙搭服务端用 index.html 作为应用入口；目录形态如果缺 index.html 真发布会 404 / 没首页。在 runHTMLPublish 里加 ensureIndexHTMLForDir 预检： - 目录形态 + 根目录缺 index.html → ErrWithHint(type=validation) 拦截 - 单文件形态（用户已明示入口）不做此校验 新增 3 个单测： - DirRequiresIndexHTML: 目录缺 index → 拦 - DirWithIndexHTMLPasses: 目录含 index → 放行 - SingleFileSkipsIndexCheck: 单文件不强求 reference 同步更新 --path 行说明。
之前 ensureIndexHTMLForDir 只校验目录形态、单文件放行。改为统一约束： 不论目录还是单文件，walker 抓到的 candidates 中必须存在 RelPath == 'index.html'。 - 目录形态：根目录下必须有 index.html - 单文件形态：文件名必须就是 index.html helper 重命名 ensureIndexHTMLForDir → ensureIndexHTML（不再有目录判断）。 错误文案 / hint 同步更新；reference --path 行同步澄清。 测试： - SingleFileSkipsIndexCheck → SingleFileRejectedIfNotNamedIndex（反转语义） - 新增 SingleFileNamedIndexPasses 覆盖单文件 index.html happy path - DirRequires/DirWithIndex 不变
`apps +access-scope-set --scope specific --targets '[]'` slipped
through Validate because the JSON-non-empty check only looks at the
string "[]" being non-empty. validateTargetsJSON's for-loop has no
body to enforce length, splitAccessScopeTargets returns three nils,
and the request body comes out as {scope:'Range'} — a 'specific'
scope with zero specific recipients. Semantically meaningless;
server behavior unspecified.
Add a len(items)==0 check at the top of validateTargetsJSON.
bytes.Buffer-based packing (introduced when html-publish moved off temp files) means highly compressible giant content would balloon process memory long before the existing post-gzip 20MB tarball size check fires. 50GB of zeros gzips to a tiny tarball but spends the buffer's full 50GB en route. Add maxHTMLPublishRawBytes = 200MB and check sum(candidate.Size) BEFORE buildHTMLPublishTarball is called. Walker has already populated c.Size from fs.DirEntry, so the sum is free.
Previously index.html requirement was Execute-only, so dry-run could pass clean and then the real publish would fail — defeats the 'dry-run = preview' contract. coverage.md misleadingly claimed 'empty dir / missing index.html rejection' was tested at dry-run. Run ensureIndexHTML in DryRun closure too and surface failures as envelope 'validation_error' field. Dry-run still exits 0 to match the repo convention of advisory dry-run; the field lets the caller (human or agent) see the impending Execute failure. Rename MissingIndexHTML_PassesDryRun → _SurfacesValidationError to match the new behavior. coverage.md now accurate.
Mirror of the same fix earlier in +update and +access-scope-get.
validateAccessScopeFlags already trims the input for the Validate
check, but the DryRun and Execute closures were still using the raw
`rctx.Str("app-id")` when building the path. " app_x " would
land in the URL as "%20%20app_x%20%20" via EncodePathSegment.
Also threads the buildAccessScopeBody error into a dry-run
'body_error' envelope field so dry-run no longer silently drops
construction failures (Finding 15).
DryRun was using rctx.Str("app-id") and rctx.Str("path") raw while
Execute trimmed both at the top. Whitespace-padded values displayed
literal space escapes in the dry-run URL and caused the path lookup
to fail (file_count=0) while Execute silently corrected them — the
contract 'dry-run previews what Execute will do' was violated. Trim
in DryRun too so the two closures stay symmetric.
writeHTMLPublishTarEntry now rejects RelPath values that look like tar-slip attempts: absolute paths, parent-directory traversal, embedded .. components, or null bytes. Walker currently never produces such values, but a future walker change or an unusual filesystem could; downstream consumers (server-side extraction) shouldn't have to be perfectly hardened against malformed input from this client. 5-line gatekeeper at the contract boundary.
90001 / 90002 magic numbers replaced with errCodeBuildFailed / errCodeAppNotFound. Docstring on the const block records that the backend owns these codes.
After 997bdfc set +list to Hidden:true and added a top-of-file⚠️ banner, the existing 'typical scenarios' section still demoed agent-facing flows the banner explicitly forbade. Strip the agent scenarios; keep the file as a human-only command reference (params, return shape, field semantics) plus a pointer to SKILL.md for the URL-extraction alternative that agents should use.
Adds an in-source comment that table view (\`--format table\`) intentionally hides description / icon_url / created_at to keep rows narrow enough for a terminal. Full fields available via JSON output. Reader of the source no longer has to wonder whether the field drop was a bug or a choice.
filepath.WalkDir + filepath.Rel inside rootPath should never produce a relative path with .. components, but defense in depth: a future walker logic change or an unusual filesystem layout shouldn't be able to inject unsafe RelPath values into htmlPublishCandidate. Extract the existing tarball-side check into isUnsafeRelPath() (path-component-aware so legitimate filenames containing ".." as a substring like archive.tar..bak are not false-flagged) and call it from both writeHTMLPublishTarEntry and the walker callback. The guard now fires at the boundary where the unsafe value would FIRST be visible, not just where it would be consumed.
raistlin042
force-pushed
the
feat/apps-domain
branch
2 times, most recently
from
May 21, 2026 09:26
6ef103b to
d82e367
Compare
- service_descriptions.json: add Apps / 应用 entry with i18n title + description so `lark-cli auth login --domain apps` and other domain-aware UIs surface a proper label instead of a bare service name - login_messages.go: add "apps" to getShortcutOnlyDomainNames() so the shortcut-only domain (no from_meta service spec) is picked up by the auth flow's domain discovery - README.md / README.zh.md: add Apps row at the end of the Features table; bump the business-domain count 17→18 and the Skills count 24→26 to match the actual repo state - skills/lark-apps/SKILL.md: add the 「身份与一次性授权」section pointing agents at `lark-cli auth login --domain apps` so all 5 apps scopes (spark:app:read/write/publish + access_scope read/write) are granted in one browser round-trip instead of prompting on each first-time shortcut invocation
liangshuo-1
approved these changes
May 21, 2026
This was referenced May 25, 2026
This was referenced Jun 1, 2026
tuxedomm
pushed a commit
to zhumiaoxin/cli
that referenced
this pull request
Jun 6, 2026
…uite#1002) Adds the apps domain to lark-cli for managing Miaoda (妙搭) applications: 6 shortcuts covering the full lifecycle (+create / +update / +list / +access-scope-set / +access-scope-get / +html-publish). Aligned with the OAPI v2 design — app_type enum (currently HTML), string scope enum (All / Tenant / Range), cursor pagination, in-memory tar.gz multipart publish flow. Namespace registered at /open-apis/spark/v1/ with spark:app.* scopes. --------- Co-authored-by: wangjiangwen-gif <286006750+wangjiangwen-gif@users.noreply.github.com>
5 tasks
This was referenced Jun 22, 2026
This was referenced Jul 6, 2026
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
appsdomain to lark-cli for managing Miaoda (妙搭) applications: 6 shortcuts covering the full lifecycle (+create/+update/+list/+access-scope-set/+access-scope-get/+html-publish). Aligned with the OAPI v2 design —app_typeenum (currentlyHTML), string scope enum (All/Tenant/Range), cursor pagination, in-memory tar.gz multipart publish flow. Namespace registered at/open-apis/spark/v1/withspark:app.*scopes.Changes
shortcuts/apps/): 6 commands + 30+ unit tests (with-race), covering body builders / validators / walker / tarball / publish orchestration / failure-hint mapping.skills/lark-apps/):SKILL.md+ 6 reference files describing typical agent scenarios, push-strategy guidance (explicit deploy vs. presentation-only), end-to-end HTML / PPT / static-site flows.+listisHidden: trueand excluded from agent flows; agents that need an existing app_id ask the user for the Miaoda app URL and extract the path segment.tests/cli_e2e/apps/): 6 files, ~40 sub-tests against the real binary; pins request URL / method / body / params shape per AGENTS.md §E2E. Live E2E intentionally deferred (no+deleteto clean up created apps; documented incoverage.md).+html-publishpacking: in-memorybytes.Buffertar.gz (no temp files); all filesystem access goes throughruntime.FileIO()for cwd-bounded path validation.--pathmust be a cwd-relative path (e.g../dist) and cannot equal cwd.Security review fixes (round 4)
Address all 16 findings from the in-house security review:
+html-publishrejects--pathresolving to cwd at both Validate andrunHTMLPublishentry;--scope publicnow requires explicit--require-login(no more fail-openrequire_login: falsedefault); dry-run scans for.git//.env*/*.pem/*.key/ SSH keys / AWS-Docker-gcloud-kube credentials and surfaces matches in awarningsenvelope field with agent behavior contract in SKILL.md.+listreference (P0): 90002 error hint no longer points at the hidden+listcommand; instructs the user to confirm app_id from the Miaoda URL.--targetsaccepted (P1):validateTargetsJSONrejects[]so--scope specificcannot produce a{scope:'Range'}body with zero recipients.maxHTMLPublishRawBytes = 200MBcap onsum(candidate.Size)before the in-memory tar+gzip so highly-compressible giant inputs cannot balloon process memory.ensureIndexHTMLand surfaces failures as avalidation_errorenvelope field (advisory, exit 0);--app-idand--pathare trimmed in dry-run too so the previewed URL matches what Execute calls.writeHTMLPublishTarEntryrejects RelPath values that look like tar-slip (absolute,.., embedded traversal, null byte) before writing the header.+access-scope-setURL builder: trims--app-idbeforeEncodePathSegment(mirrors the earlier fix in+update/+access-scope-get); dry-run surfacesbuildAccessScopeBodyerrors as abody_errorfield instead of swallowing.lark-apps-list.mdstripped of agent-facing scenarios that contradicted theHidden: truebanner; named consterrCodeBuildFailed/errCodeAppNotFoundreplace the 90001 / 90002 magic numbers;+listtable-view column selection documented in source;coverage.mdupdated to reflect the new dry-run advisory semantics.Test Plan
go test ./shortcuts/apps/... -race -count=3— all unit tests pass with race detectiongo test ./tests/cli_e2e/apps/... -count=3— ~40 dry-run sub-tests pass against the real binarygo vet ./...+gofmt -l .cleango mod tidy— no drift in go.mod / go.sumgolangci-lint --new-from-rev=origin/main— 0 issuesRelated Issues