Skip to content

fix: add new scope entries to scope priorities - #1050

Merged
MaxHuang22 merged 1 commit into
mainfrom
fix/add-new-scopes
May 22, 2026
Merged

fix: add new scope entries to scope priorities#1050
MaxHuang22 merged 1 commit into
mainfrom
fix/add-new-scopes

Conversation

@MaxHuang22

@MaxHuang22 MaxHuang22 commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Add 22 new scope entries to the scope priorities registry. These scopes cover new API capabilities across spark, corehr, directory, docs, drive, im, minutes, okr, and search domains.

Changes

  • Append 22 new scope entries to internal/registry/scope_priorities.json
  • No modifications to existing scope entries (scores and recommend values unchanged)

Test Plan

  • skipped: make unit-test — data-only change (JSON registry), no Go code modified
  • skipped: validate — no shortcut or command logic changed
  • skipped: local-eval — no behavioral change to test
  • skipped: acceptance-reviewer — no user-facing command change
  • manual verification: confirmed diff is pure additions (110 insertions, 0 deletions), JSON is valid, and all 22 new scope names are unique

Related Issues

N/A

Summary by CodeRabbit

  • Chores
    • Updated scope priority configuration across multiple services (Docs, Search, Drive, CoreHR, IM, Minutes, OKR, and Directory) with new scoring and recommendation settings.

Review Change Stack

Change-Id: I2e7bb2e2971bfb071c3976d349b2d2bc4cc485ae
@MaxHuang22 MaxHuang22 added the bug Something isn't working label May 22, 2026
@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label May 22, 2026
@coderabbitai

coderabbitai Bot commented May 22, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8a2bdbdb-9aa9-4131-8c2c-85a7d0778d59

📥 Commits

Reviewing files that changed from the base of the PR and between 4582dfd and ef9b488.

📒 Files selected for processing (1)
  • internal/registry/scope_priorities.json

📝 Walkthrough

Walkthrough

This PR adds 110 new scope-priority entries to the registry configuration file, extending coverage across nine service domains (Spark, Docs, CoreHR, IM, Minutes, Search, Drive, OKR, Directory). Each entry specifies a scope name, final score, and recommendation flag using a consistent JSON schema.

Changes

Scope Priorities Registry

Layer / File(s) Summary
New scope-priority entries
internal/registry/scope_priorities.json
110 new JSON objects appended after existing entries, each defining scope_name, final_score, and recommend for newly covered permission scopes across multiple service domains.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • larksuite/cli#370: The scope audit test reads registry.LoadScopePriorities() to populate the in_priority field—the test output will directly reflect these new priority entries.

Suggested labels

size/XL

Suggested reviewers

  • liangshuo-1

Poem

🐰 A hundred scopes hop into the registry,
With scores and flags in perfect harmony,
Spark and Docs and Directories too,
All permissions fresh and priorities true! 📋✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change of adding new scope entries to the scope priorities registry.
Description check ✅ Passed The description includes all required template sections with comprehensive details about the changes, test plan reasoning, and verification steps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/add-new-scopes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented May 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.76%. Comparing base (e19e090) to head (ef9b488).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1050      +/-   ##
==========================================
+ Coverage   67.68%   67.76%   +0.07%     
==========================================
  Files         576      590      +14     
  Lines       54548    55194     +646     
==========================================
+ Hits        36919    37400     +481     
- Misses      14568    14682     +114     
- Partials     3061     3112      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@ef9b488268f2488dd4fabb88869790212a67d5cb

🧩 Skill update

npx skills add larksuite/cli#fix/add-new-scopes -y -g

@MaxHuang22
MaxHuang22 merged commit 4b22231 into main May 22, 2026
21 checks passed
@MaxHuang22
MaxHuang22 deleted the fix/add-new-scopes branch May 22, 2026 11:48
@liangshuo-1 liangshuo-1 mentioned this pull request May 22, 2026
3 tasks
tuxedomm pushed a commit to zhumiaoxin/cli that referenced this pull request Jun 6, 2026
Change-Id: I2e7bb2e2971bfb071c3976d349b2d2bc4cc485ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants