Skip to content

fix: whiteboard skill - #1166

Merged
syh-cpdsss merged 1 commit into
mainfrom
fix/whiteboard_skill
May 29, 2026
Merged

fix: whiteboard skill#1166
syh-cpdsss merged 1 commit into
mainfrom
fix/whiteboard_skill

Conversation

@syh-cpdsss

@syh-cpdsss syh-cpdsss commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixed some mistakes and outdated instructions in lark-whiteboard skill

Changes

  • fixed wrong command instructions
  • fixed outdated --overwrite instruction

Test Plan

  • Unit tests pass
  • Skills evaluated locally

Related Issues

  • None

Summary by CodeRabbit

  • Documentation
    • Clarified whiteboard document fetching instructions for improved accuracy
    • Updated workflow guidance for writing and overwriting whiteboard content
    • Fixed code examples to use correct syntax in sample configurations

Review Change Stack

Change-Id: Ib1da37c1520d7697eaee7146555185ffbc749217
@syh-cpdsss
syh-cpdsss requested a review from zkh-bytedance May 29, 2026 03:54
@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9a61c669-c37e-4b0d-ad05-db53a9db7eb2

📥 Commits

Reviewing files that changed from the base of the PR and between a2cc5e1 and 3961dbb.

📒 Files selected for processing (2)
  • skills/lark-whiteboard/SKILL.md
  • skills/lark-whiteboard/references/lark-whiteboard-update.md

📝 Walkthrough

Walkthrough

This PR refines the lark-whiteboard skill documentation by simplifying CLI commands, updating workflow routing and board-write behavior, and correcting Mermaid syntax examples. Changes span SKILL.md instructions and a reference example document.

Changes

Lark-Whiteboard Skill Documentation Refinements

Layer / File(s) Summary
CLI Command Simplifications
skills/lark-whiteboard/SKILL.md
Removed the forced stdin update regulation that required --source - --input_format <格式> for local-file data, and removed the --api-version v2 flag from the lark-cli docs +fetch invocation when extracting whiteboard tokens from existing documents.
Routing Table & Overwrite Behavior Refinements
skills/lark-whiteboard/SKILL.md
Expanded the Mermaid routing table to cover additional chart types (including "流程图"), and replaced the prior two-step dry-run + confirmation workflow with clearer --overwrite guidance that distinguishes incremental vs. overwrite behavior in the lark-cli whiteboard +update command.
Reference Example Syntax Correction
skills/lark-whiteboard/references/lark-whiteboard-update.md
Corrected Mermaid arrow syntax in Example 2 by unescaping HTML entities (--&gt;-->) while preserving conditional branch notation (`

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • larksuite/cli#649: Related whiteboard workflow pinning and dry-run/confirmation stage updates at same workflow logic level.
  • larksuite/cli#617: Concurrent edits to the same whiteboard write workflow sections, updating dry-run/confirm pipeline text and version constraints.
  • larksuite/cli#1097: Overlapping updates to whiteboard token extraction, routing, and overwrite strategy guidance across coordinated skill workflows.

Suggested labels

size/M

Suggested reviewers

  • zkh-bytedance
  • zl-bytedance

Poem

🐰 A whiteboard reborn, the arrows now flow,
--overwrite whispers what we all should know,
No stdin rules, no v2 in sight,
The Mermaid now dances in HTML-free light!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix: whiteboard skill' is vague and generic, using non-descriptive terms that don't convey specific details about what was fixed. Consider using a more specific title that describes the actual fixes, such as 'fix: update lark-whiteboard command instructions and --overwrite behavior' or similar.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description covers the required template sections (Summary, Changes, Test Plan, Related Issues) but lacks sufficient detail about what was actually changed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/whiteboard_skill

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label May 29, 2026
@codecov

codecov Bot commented May 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.77%. Comparing base (a2cc5e1) to head (3961dbb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1166   +/-   ##
=======================================
  Coverage   68.77%   68.77%           
=======================================
  Files         628      628           
  Lines       58670    58670           
=======================================
  Hits        40353    40353           
  Misses      15021    15021           
  Partials     3296     3296           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@3961dbb94ca3634a50b5cf732f7971dad6b8d3b0

🧩 Skill update

npx skills add larksuite/cli#fix/whiteboard_skill -y -g

@syh-cpdsss
syh-cpdsss merged commit 0a2c320 into main May 29, 2026
22 checks passed
@syh-cpdsss
syh-cpdsss deleted the fix/whiteboard_skill branch May 29, 2026 06:23
@coderabbitai coderabbitai Bot mentioned this pull request May 30, 2026
2 tasks
tuxedomm pushed a commit to zhumiaoxin/cli that referenced this pull request Jun 6, 2026
Change-Id: Ib1da37c1520d7697eaee7146555185ffbc749217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants