feat(wiki): support appid member type#1235
Conversation
CCM-Harness: code
📝 WalkthroughWalkthroughThis PR extends the wiki space-member shortcuts to accept ChangesWiki App Member Support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1235 +/- ##
=======================================
Coverage 69.22% 69.22%
=======================================
Files 635 635
Lines 59689 59689
=======================================
Hits 41322 41322
Misses 15033 15033
Partials 3334 3334 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@shortcuts/wiki/wiki_member_helpers.go`:
- Around line 15-17: Update the wikiMemberTypes allowlist to match the
documented enum for Lark/Feishu Wiki V2 by removing the unsupported "appid"
entry from the slice named wikiMemberTypes; ensure the remaining values are
exactly "openchat", "userid", "email", "opendepartmentid", "openid", "unionid"
(reorder if necessary) and run any unit/integration tests that exercise member
creation/deletion to confirm no other code expects "appid"; if an app-related
member type is actually required, replace "appid" with the correct documented
enum name and adjust code paths that handle member_type accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 27e697a4-6243-4177-b2a7-035212baf4cb
📒 Files selected for processing (7)
shortcuts/wiki/wiki_member_helpers.goshortcuts/wiki/wiki_member_test.goskill-template/domains/wiki.mdskills/lark-wiki/SKILL.mdskills/lark-wiki/references/lark-wiki-member-add.mdskills/lark-wiki/references/lark-wiki-member-remove.mdtests/cli_e2e/wiki/wiki_member_add_dryrun_test.go
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@3fb4d95cf6eddcddc576e3b05208b10a35fb2570🧩 Skill updatenpx skills add larksuite/cli#feat/wiki_member -y -g |
CCM-Harness: code
Summary
reference docs so agents can correctly choose
--member-type=appidfor app membership flows.Summary by CodeRabbit
New Features
--member-type=appidin addition to users, groups, and departments.Documentation
Tests