feat(sheets): add gridline show/hide shortcuts#1264
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughAdds two sheet-level CLI shortcuts, +sheet-show-gridline and +sheet-hide-gridline, which accept spreadsheet and sheet locators, build show/hide gridline payloads, and invoke the existing modify_workbook_structure tool. Includes flag definitions, implementation, batch dispatch wiring, tests, registration, and docs. ChangesSheet Gridline Toggle Shortcuts
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1264 +/- ##
=======================================
Coverage 69.64% 69.64%
=======================================
Files 666 666
Lines 64413 64421 +8
=======================================
+ Hits 44861 44869 +8
Misses 15943 15943
Partials 3609 3609 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@6e067f2180dd506de70e333a6f0625b055b6c51a🧩 Skill updatenpx skills add zhengzhijiej-tech/cli#feat/sheet-gridline -y -g |
1f641bb to
4a5b80e
Compare
4a5b80e to
6e067f2
Compare
0ff7f04
into
larksuite:feat/lark-sheets-develop
feat(sheets): add gridline show/hide shortcuts
What
Add two worksheet-level shortcuts to toggle gridline visibility:
+sheet-show-gridline+sheet-hide-gridlineBoth target the
modify_workbook_structuretool via theshow_gridline/hide_gridlineoperations. This mirrors the existing+sheet-hide/+sheet-unhidetwo-state pattern — the show/hide intent lives in the operation enum, so no--visibleflag is needed.Changes
shortcuts/sheets/lark_sheet_workbook.go:sheetGridlineInput+newSheetGridlineShortcutfactory + the two shortcutsshortcuts/sheets/shortcuts.go: registrationshortcuts/sheets/batch_op_dispatch.go: two+batch-updatesub-op mappings (reusingsheetGridlineInput)shortcuts/sheets/data/flag-defs.json+flag_defs_gen.go: flag definitions (four locator flags each, no own flag — same set as+sheet-hide)Testing
go test ./shortcuts/sheets/...passes; the data-driven batch contract tests (TestBatchOp_*) automatically cover the new shortcuts.modify_workbook_structurewithoperation: show_gridline/hide_gridlineand the sheet selector.Server-side tool support is delivered separately; the flag-defs / reference docs are normally synced from the spec source.
Summary by CodeRabbit
New Features
Documentation
Tests