Feat/riscv64 build#1297
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis PR adds ChangesRISC-V 64-bit Architecture Support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1297 +/- ##
==========================================
+ Coverage 70.39% 70.46% +0.07%
==========================================
Files 677 679 +2
Lines 65599 65611 +12
==========================================
+ Hits 46176 46231 +55
+ Misses 15757 15726 -31
+ Partials 3666 3654 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@bb8691ba0d8dceaf473b4194b88a57c1a3249ec2🧩 Skill updatenpx skills add rockyzhang/cli#feat/riscv64-build -y -g |
|
Superseded by #1382. Thanks @rockyzhang for the contribution! 🎉 Your two original commits were cherry-picked onto the current main, with a follow-up commit applying review feedback: the Makefile -race guard now honors a command-line make GOARCH=riscv64 override, plus a trailing-newline fix. Closing in favor of #1382. |
Summary
Add riscv64 as a supported architecture so the CLI builds and installs
natively on RISC-V hardware.
Changes
Makefile: make -race flag conditional. Go's race detector is not
available on linux/riscv64 before Go 1.26, so "make unit-test" fails
without this guard.
Release pipeline: add riscv64 to .goreleaser.yml, package.json,
scripts/build-pkg-pr-new.sh, and scripts/install.js.
Test Plan
Unit tests pass on riscv64 hardware (make unit-test).
Release workflow verified: produced a working lark-cli binary that
runs natively on linux/riscv64.
Related Issues
None
Summary by CodeRabbit
New Features
Documentation